Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters based on allowed user agent (regexp) #232

Merged
merged 1 commit into from
May 6, 2024
Merged

Conversation

plor
Copy link
Contributor

@plor plor commented May 5, 2024

We will need to test that our regex validation matches between JS and golang. I'm compiling based on the value in the db, so it may differ slightly.

@plor plor requested a review from wtfsayo May 5, 2024 21:14
@plor plor linked an issue May 5, 2024 that may be closed by this pull request
@wtfsayo wtfsayo merged commit 3da5e79 into develop May 6, 2024
3 checks passed
@wtfsayo wtfsayo deleted the rule-user-agent branch May 6, 2024 04:33
@wtfsayo
Copy link
Contributor

wtfsayo commented May 6, 2024

the regex in DB as saved without prefix / and suffix / so always required to created new RegExp(regexfromdb)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement user agent filter handler
2 participants