Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added global guard etc! #259

Merged
merged 3 commits into from
May 19, 2024
Merged

added global guard etc! #259

merged 3 commits into from
May 19, 2024

Conversation

wtfsayo
Copy link
Contributor

@wtfsayo wtfsayo commented May 19, 2024

  • added global guard!
  • authorization check!

@wtfsayo wtfsayo requested a review from plor May 19, 2024 19:32
plor
plor approved these changes May 19, 2024
View reviewed changes
Copy link
Contributor

@plor plor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to see this documented and unit tested well. I don't fully understand how the authorization is enforced, which opens up for future bugs that could be quite negative.

@wtfsayo wtfsayo merged commit dbe0192 into develop May 19, 2024
2 checks passed
@wtfsayo wtfsayo deleted the add-authorization-check branch May 19, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plor plor plor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wtfsayo @plor