move to nanoid for tenant, user, apps! #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plor
suggested changes
May 22, 2024
There was a problem hiding this comment.
I would prefer if a change like this was documented better. For example referencing https://zelark.github.io/nano-id-cc/ to show what the probability of collision is.
| @@ -83,6 +84,7 @@ export class AppsService { | |||
| if (!tenants) return; | |||
| const newApp = await this.prisma.client.app.create({ | |||
| data: { | |||
| id: nanoid(10), | |||
There was a problem hiding this comment.
Is there any implications of 10 here? I'm not familiar with nanoid, so not sure what benefit this has over 9, or what would be gained by going to 11. This is the type of decision that is good to document so future devs know what's going on. I'd recommend making a constant since this is used in several places (2), and the constant can be named and commented appropriately.
There was a problem hiding this comment.
https://zelark.github.io/nano-id-cc/
10 character is strong enough to not repeat !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.