Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swapped out web3modal for connectkit #287

Merged
merged 1 commit into from
May 27, 2024
Merged

swapped out web3modal for connectkit #287

merged 1 commit into from
May 27, 2024

Conversation

wtfsayo
Copy link
Contributor

@wtfsayo wtfsayo commented May 27, 2024

  • fixes signout on network change
  • no more connect issues

@wtfsayo wtfsayo requested a review from plor May 27, 2024 13:47
Copy link
Contributor

@plor plor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, but not sure about the possible secrets

Comment on lines +28 to +32
`https://eth-mainnet.rpc.grove.city/v1/1eec3963`
),
[base.id]: http(`https://base-mainnet.rpc.grove.city/v1/1eec3963`),
[gnosis.id]: http(`https://gnosischain-mainnet.rpc.grove.city/v1/1eec3963`),
[optimism.id]: http(`https://optimism-mainnet.rpc.grove.city/v1/1eec3963`),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean to be committing these?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no regrets! will be disabling!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to swap to own endpoints at some point

@wtfsayo wtfsayo merged commit 251f4f0 into develop May 27, 2024
@wtfsayo wtfsayo deleted the swap-to-connectkit branch May 27, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants