Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: coordinate docker setup #90

Merged
merged 6 commits into from
Feb 14, 2024
Merged

WIP: coordinate docker setup #90

merged 6 commits into from
Feb 14, 2024

Conversation

plor
Copy link
Contributor

@plor plor commented Feb 8, 2024

I'm pushing the docker stuff I've been working on for visibility, not working yet.

Copy link
Contributor Author

@plor plor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks pretty good, just one question really

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this a top level file? Shouldn't it be in the backend directory?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need prisma file to generate prisma stuff somehow

@wtfsayo wtfsayo requested review from wtfsayo and removed request for wtfsayo February 14, 2024 15:22
@wtfsayo
Copy link
Contributor

wtfsayo commented Feb 14, 2024

@plor since this branch has some conflicts with recent merged PR, do you wanna look at conflicts, mostly it's in gateway stuff

Rest of the stuff(Docker related) should be overwrite really!

@plor
Copy link
Contributor Author

plor commented Feb 14, 2024

Yeah, that was my bad. I'll be better about git workflows to avoid this going forward.

@wtfsayo wtfsayo merged commit d0eb2ef into develop Feb 14, 2024
@wtfsayo wtfsayo deleted the require_filters branch February 14, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants