Removed root nodejs clutter, migrated to sha256, justfile commands #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR aims to simplify and clean the repo, decentralise js repos, migrate to SHA256 for hashing as discussed! todo: just migrate doesn't work unless db url provided directly via string!
|
This PR is being deployed to Railway 🚅 portal-frontend: ◻️ REMOVED |
plor
approved these changes
Feb 11, 2024
Comment on lines
+14
to
+26
| cd ./web-portal/backend && pnpm install && pnpm start | ||
| build-backend: | ||
| cd ./web-portal/frontend && pnpm install && pnpm build | ||
| serve-backend: | ||
| cd ./web-portal/backend && pnpm install && pnpm start:prod | ||
|
|
||
|
|
||
| dev-frontend: | ||
| cd ./web-portal/frontend && pnpm install && pnpm dev | ||
| build-frontend: | ||
| cd ./web-portal/frontend && pnpm install && pnpm build | ||
| serve-frontend: | ||
| cd ./web-portal/frontend && pnpm install && pnpm start |
There was a problem hiding this comment.
If you put a justfile in the subdirectory you can do @just web-portal/build to define the actions closer to the code and avoid the cd. This is fine though. It might be good to bundle all the builds into a build-all or just build.
| @@ -1,13 +1,26 @@ | |||
| default: | |||
| @just --list | |||
|
|
|||
| build: | |||
| @just gateway/build | |||
There was a problem hiding this comment.
removing this disconnects the gateway from the top level
| } | ||
|
|
||
| generator client { | ||
| provider = "prisma-client-js" | ||
| output = "../../.generated/client" | ||
| output = "../../web-portal/backend/.generated/client" |
There was a problem hiding this comment.
Did the idea to use a shared volume not pan out?
| async createAuthKey(tenantId: string): Promise<any> { | ||
| const secretKey = 'sk_' + randomBytes(39).toString('hex'); // <-- TODO: figure out final key format | ||
|
|
||
| const hashedKey = await bcrypt.hash(secretKey, this.salt); | ||
| const hashedKey = createHash('sha256').update(secretKey).digest('hex'); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to simplify and clean the repo, decentralise js repos, migrate to SHA256 for hashing as discussed!
todo: just migrate doesn't work unless db url provided directly via string!
todo: make session more stable; next cookies not working best!!!