Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix Python help url resolution on Server Web and Workbench (#4837)
### Description - addresses part of #4274 - a follow-up to #4814 to fix Python help docs in Positron Server and Positron on Workbench #### Screenshots of the issue <img width="865" alt="image" src="https://github.com/user-attachments/assets/631488c4-cee6-49ec-8c9a-314830c925e7"> ![image](https://github.com/user-attachments/assets/b0594155-f357-46e6-8a61-4a3ac211f600) #### What it looks like now! <img width="1727" alt="image" src="https://github.com/user-attachments/assets/313a33a1-4698-47ac-8df2-314a6cc034df"> #### Implementation Notes - adds back in the `sourceUrl.pathname` fix that I should have had in #4814, but accidentally deleted - appends the search query to the target path, which was getting dropped in the proxied request in `src/vs/server/node/webClientServer.ts` Note: the change to `src/vs/server/node/webClientServer.ts` needs to be contributed to our upstream. ### QA Notes In Positron Server Web and Positron on Workbench: 1. Select a Python interpreter 2. In the Console, get help for something, e.g. `import time` then `?time` and hit Enter 3. What to expect in the Help Pane: - the pane should display the help content with styling that matches the current IDE theme - links to other help pages should load and work when clicked - there shouldn't be 404 Not Found errors in the Developer Console or Network tab for paths referenced in the help HTML --------- Co-authored-by: Brian Lambert <brianlambert@gmail.com> Co-authored-by: Jonathan <jonathan@rstudio.com>
- Loading branch information