Typescript migration #123
Merged
Typescript migration #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FranckLecuyer
force-pushed
the
typescript_migration
branch
5 times, most recently
from
eee9f91 to
f480622
Compare
FranckLecuyer
force-pushed
the
typescript_migration
branch
from
f480622 to
e103b4d
Compare
anistouri
reviewed
Nov 13, 2024
src/components/network-map-viewer/network/layers/arrow-layer.ts
Outdated
Show resolved
Hide resolved
src/components/network-map-viewer/network/layers/arrow-layer.ts
Outdated
Show resolved
Hide resolved
anistouri
reviewed
Nov 13, 2024
anistouri
force-pushed
the
typescript_migration
branch
from
254c7e2 to
2338a96
Compare
Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
FranckLecuyer
force-pushed
the
typescript_migration
branch
from
2338a96 to
1ee57c3
Compare
Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
anistouri
approved these changes
Nov 15, 2024
|
flo-dup
pushed a commit
that referenced
this pull request
Nov 21, 2024
Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com> Co-authored-by: Arnaud Marant <amarant@users.noreply.github.com> Co-authored-by: Tristan Chuine <tristan.chuine_externe@rte-france.com>
flo-dup
pushed a commit
that referenced
this pull request
Nov 21, 2024
Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com> Co-authored-by: Arnaud Marant <amarant@users.noreply.github.com> Co-authored-by: Tristan Chuine <tristan.chuine_externe@rte-france.com>
TheMaskedTurtle
added a commit
that referenced
this pull request
Dec 4, 2024
This reverts commit b2cedbf.
TheMaskedTurtle
added a commit
that referenced
this pull request
Dec 4, 2024
This reverts commit b2cedbf. Signed-off-by: Joris Mancini <joris.mancini_externe@rte-france.com>
flo-dup
pushed a commit
that referenced
this pull request
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
This PR migrate the remaining files in JavaScript into TypeScript.
What is the current behavior?
Some files are still in JavaScript
What is the new behavior (if this is a feature change)?
All files are now in TypeScript
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: