Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Typescript migration (#123)" #131

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Revert "Typescript migration (#123)" #131

merged 1 commit into from
Dec 4, 2024

Conversation

TheMaskedTurtle
Copy link
Contributor

@TheMaskedTurtle TheMaskedTurtle commented Dec 4, 2024

This reverts commit b2cedbf.

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?
TS migration introduced bugs, it looks difficult to solve this, so we temporarily revert

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

This reverts commit b2cedbf.

Signed-off-by: Joris Mancini <joris.mancini_externe@rte-france.com>
Copy link

sonarcloud bot commented Dec 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarQube Cloud

@FranckLecuyer FranckLecuyer self-requested a review December 4, 2024 08:58
@Tristan-WorkGH Tristan-WorkGH self-assigned this Dec 4, 2024
@Tristan-WorkGH Tristan-WorkGH self-requested a review December 4, 2024 09:01
@flo-dup flo-dup merged commit b93f62b into main Dec 4, 2024
5 of 6 checks passed
@flo-dup flo-dup deleted the revert-ts branch December 4, 2024 09:44
@Tristan-WorkGH Tristan-WorkGH mentioned this pull request Dec 5, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants