removed code relative to cnecs in series with a pst #1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philippe Edwards <philippe.edwards@rte-france.com>
…e_cnecs_series_pst_feature Signed-off-by: Philippe Edwards <philippe.edwards@rte-france.com>
Signed-off-by: Philippe Edwards <philippe.edwards@rte-france.com>
|
I'm not sure what relevant test I could add. |
bqth29
reviewed
May 24, 2024
Comment on lines
58
to
61
| public enum UnoptimizedCnecFillerRule { | ||
| MARGIN_DECREASE, | ||
| PST_LIMITATION | ||
| } |
Comment on lines
39
to
40
| public static final String VARIABLE_NOT_CREATED = "%s variable has not yet been created for Cnec %s (side %s)"; | ||
| public static final String OPTIMIZE_CNEC_BINARY = "Optimize cnec binary"; |
There was a problem hiding this comment.
No. I can't even seem to find where it was used before.
Comment on lines
46
to
50
| public UnoptimizedCnecFiller(OptimizationPerimeter optimizationContext, | ||
| Set<FlowCnec> flowCnecs, | ||
| FlowResult prePerimeterFlowResult, | ||
| UnoptimizedCnecParameters unoptimizedCnecParameters, | ||
| RangeActionsOptimizationParameters rangeActionParameters) { |
There was a problem hiding this comment.
It appears optimizationContext and rangeActionParameters are no longer required
...ain/java/com/powsybl/openrao/searchtreerao/commons/parameters/UnoptimizedCnecParameters.java
Outdated
Show resolved
Hide resolved
Comment on lines
30
to
32
| public static UnoptimizedCnecParameters build(NotOptimizedCnecsParameters parameters, Set<String> operatorsNotSharingCras) { | ||
| if (parameters.getDoNotOptimizeCurativeCnecsForTsosWithoutCras()) { | ||
| return new UnoptimizedCnecParameters(operatorsNotSharingCras); |
There was a problem hiding this comment.
Is this actually still relevant since it is only a set of strings?
There was a problem hiding this comment.
Also can you one-line this method?
There was a problem hiding this comment.
All the other parameters have builders so it allows for slightly more homogeneity
Signed-off-by: Philippe Edwards <philippe.edwards@rte-france.com>
…powsybl/open-rao into remove_cnecs_series_pst_feature
bqth29
previously approved these changes
May 24, 2024
…e_cnecs_series_pst_feature Signed-off-by: Philippe Edwards <philippe.edwards@rte-france.com>
pet-mit
approved these changes
Jun 20, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Removing a feature for which the specifications were misunderstood
What is the current behavior?
We do not include in the functional part of the objective function cnecs that are linked with a pst in the "do-not-optimize-cnec-secured-by-its-pst" parameter, when taps would be sufficient to solve constraints on that cnec.
This isn't exactly what the TSOs wanted.
What is the new behavior (if this is a feature change)?
The feature is removed.
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
You should remove the parameter "do-not-optimize-cnec-secured-by-its-pst".
If you were using that feature, please contact us so we can understand why you were using this feature, and what exactly the need for it is on your end, so we can try find a better solution for you.
Other information: