Simplify objective function evaluators #1109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Mitri <peter.mitri@rte-france.com>
pet-mit
force-pushed
the
no_sensi_in_evaluators
branch
from
6a73eff to
623d159
Compare
pet-mit
changed the title
Signed-off-by: Peter Mitri <peter.mitri@rte-france.com>
…tEvaluator Signed-off-by: Peter Mitri <peter.mitri@rte-france.com>
Signed-off-by: Peter Mitri <peter.mitri@rte-france.com>
Signed-off-by: Peter Mitri <peter.mitri@rte-france.com>
pet-mit
added
breaking-change
Signed-off-by: Peter Mitri <peter.mitri@rte-france.com>
|
fails on internal tests 23.2.6 & 23.2.9 => to check |
…ionStatus Signed-off-by: Peter Mitri <peter.mitri@rte-france.com>
Signed-off-by: Peter Mitri <peter.mitri@rte-france.com>
Signed-off-by: Peter Mitri <peter.mitri@rte-france.com>
Signed-off-by: Peter Mitri <peter.mitri@rte-france.com>
Signed-off-by: Peter Mitri <peter.mitri@rte-france.com>
phiedw
reviewed
Aug 19, 2024
Comment on lines
199
to
205
| || secondPreventivePerimeterResult.getSensitivityStatus() == FAILURE) { | ||
| return FAILURE; | ||
| } | ||
| if (postContingencyResults.entrySet().stream().anyMatch(entry -> | ||
| Objects.isNull(entry.getValue()) || entry.getValue().getSensitivityStatus(entry.getKey()) == FAILURE)) { | ||
| return PARTIAL_FAILURE; | ||
| } |
There was a problem hiding this comment.
can any of the results return partial_failure?
Signed-off-by: Peter Mitri <peter.mitri@rte-france.com>
phiedw
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No but helps prepare a fix for #1048
What kind of change does this PR introduce?
Housekeeping
What is the current behavior?
In order to be evaluated, an objective function needs:
These were mainly used by the UnoptimizedCnecsInSeriesWithPsts evaluator, which has been removed in removed code relative to cnecs in series with a pst #1015.
SensitivityResult is currently only used in the sensitivity failure overcost evaluator, which needs to know if any state failed load-flow computations.
What is the new behavior (if this is a feature change)?
The 2 objects have been removed from evaluation inputs, making it simpler.
And a pre-processing is used to make sure that the sensi failure overcost evaluator behaves like before.
This pre-processing needs the addition of a new ComputationStatus : PARTIAL_FAILURE.
This new value means that some sensitivity or loadflow computations failed, but not all.
Does this PR introduce a breaking change or deprecate an API?
What changes might users need to make in their application due to this PR? (migration steps)
Users have to take into account the existence of a new ComputationStatus.PARTIAL_FAILURE value in their applications that use RaoResult::getComputationStatus()