-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rao parameters forbid cost increase always true #1112
base: main
Are you sure you want to change the base?
Conversation
59f6dd5
to
3a7b4bd
Compare
43c2d26
to
3f5bef7
Compare
8576a0c
to
c983910
Compare
c983910
to
6ef7c93
Compare
6ef7c93
to
00713a3
Compare
7fc9c43
to
6607c13
Compare
6607c13
to
b1a5757
Compare
82aacb6
to
f57fcdb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks good to me, with a minor comment.
@@ -82,14 +82,9 @@ Feature: US 12.15: export different reason per perimeter in SWE CNE | |||
Given crac creation parameters file is "epic12/CimCracCreationParameters_MonitorLeftSide.json" | |||
Given configuration file is "epic12/raoParametersSweIDCC_minObjectiveDisabled2P.json" | |||
When I launch search_tree_rao at "2021-04-02 05:00" | |||
Then the calculation partially fails |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why exactly all those tests are impacted in the same way. Maybe @phiedw it would be good to explicitly understand why.
… acceptable) Signed-off-by: Pauline Jean-Marie <pauline.jean-marie@artelys.com>
Signed-off-by: Pauline Jean-Marie <pauline.jean-marie@artelys.com>
f57fcdb
to
159c8e2
Compare
Signed-off-by: Philippe Edwards <philippe.edwards@rte-france.com>
…ps://github.com/powsybl/open-rao into rao_parameters_forbid_cost_increase_always_true Signed-off-by: Philippe Edwards <philippe.edwards@rte-france.com>
Signed-off-by: Philippe Edwards <philippe.edwards@rte-france.com>
Signed-off-by: Philippe Edwards <philippe.edwards@rte-france.com>
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Remove the line "forbid-cost-increase" from their yml or json rao parameters file.
Increase rao parameters file version to 2.5.
Other information: