Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rao parameters forbid cost increase always true #1112

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

pjeanmarie
Copy link
Member

@pjeanmarie pjeanmarie commented Aug 9, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Remove the line "forbid-cost-increase" from their yml or json rao parameters file.
Increase rao parameters file version to 2.5.

Other information:

@pjeanmarie pjeanmarie self-assigned this Aug 9, 2024
@pjeanmarie pjeanmarie marked this pull request as draft August 9, 2024 15:55
@pjeanmarie pjeanmarie changed the title Rao parameters forbid cost increase always true [WIP] Rao parameters forbid cost increase always true Aug 9, 2024
@pjeanmarie pjeanmarie linked an issue Aug 9, 2024 that may be closed by this pull request
@pjeanmarie pjeanmarie force-pushed the rao_parameters_forbid_cost_increase_always_true branch 3 times, most recently from 59f6dd5 to 3a7b4bd Compare August 14, 2024 15:07
@pjeanmarie pjeanmarie marked this pull request as ready for review August 14, 2024 15:15
@pjeanmarie pjeanmarie added the PR: waiting-for-review This PR is waiting to be reviewed label Aug 14, 2024
@pjeanmarie pjeanmarie changed the title [WIP] Rao parameters forbid cost increase always true Rao parameters forbid cost increase always true Aug 14, 2024
@pjeanmarie pjeanmarie requested a review from obrix August 14, 2024 15:16
@pjeanmarie pjeanmarie force-pushed the rao_parameters_forbid_cost_increase_always_true branch 2 times, most recently from 43c2d26 to 3f5bef7 Compare August 14, 2024 15:25
@pjeanmarie pjeanmarie added the breaking-change Changes could break users' code label Aug 14, 2024
@pjeanmarie pjeanmarie force-pushed the rao_parameters_forbid_cost_increase_always_true branch 2 times, most recently from 8576a0c to c983910 Compare September 3, 2024 09:01
@pjeanmarie pjeanmarie force-pushed the rao_parameters_forbid_cost_increase_always_true branch from c983910 to 6ef7c93 Compare September 17, 2024 12:44
@pjeanmarie pjeanmarie requested a review from phiedw September 18, 2024 12:58
@pjeanmarie pjeanmarie force-pushed the rao_parameters_forbid_cost_increase_always_true branch from 6ef7c93 to 00713a3 Compare September 23, 2024 08:01
@pjeanmarie pjeanmarie force-pushed the rao_parameters_forbid_cost_increase_always_true branch from 7fc9c43 to 6607c13 Compare October 2, 2024 12:02
@pjeanmarie pjeanmarie force-pushed the rao_parameters_forbid_cost_increase_always_true branch from 6607c13 to b1a5757 Compare October 28, 2024 10:26
@pjeanmarie pjeanmarie force-pushed the rao_parameters_forbid_cost_increase_always_true branch from 82aacb6 to f57fcdb Compare November 15, 2024 09:14
Copy link
Member

@obrix obrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good to me, with a minor comment.

@@ -82,14 +82,9 @@ Feature: US 12.15: export different reason per perimeter in SWE CNE
Given crac creation parameters file is "epic12/CimCracCreationParameters_MonitorLeftSide.json"
Given configuration file is "epic12/raoParametersSweIDCC_minObjectiveDisabled2P.json"
When I launch search_tree_rao at "2021-04-02 05:00"
Then the calculation partially fails
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why exactly all those tests are impacted in the same way. Maybe @phiedw it would be good to explicitly understand why.

Pauline Jean-Marie added 2 commits November 29, 2024 10:51
… acceptable)

Signed-off-by: Pauline Jean-Marie <pauline.jean-marie@artelys.com>
Signed-off-by: Pauline Jean-Marie <pauline.jean-marie@artelys.com>
@pjeanmarie pjeanmarie force-pushed the rao_parameters_forbid_cost_increase_always_true branch from f57fcdb to 159c8e2 Compare November 29, 2024 10:17
…ps://github.com/powsybl/open-rao into rao_parameters_forbid_cost_increase_always_true

Signed-off-by: Philippe Edwards <philippe.edwards@rte-france.com>
Signed-off-by: Philippe Edwards <philippe.edwards@rte-france.com>
Signed-off-by: Philippe Edwards <philippe.edwards@rte-france.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Changes could break users' code PR: waiting-for-review This PR is waiting to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make RaoParameters generic
3 participants