Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AssetLoaded event #315

Merged
merged 8 commits into from
Jul 23, 2019
Merged

Add AssetLoaded event #315

merged 8 commits into from
Jul 23, 2019

Conversation

AstraLuma
Copy link
Member

@AstraLuma AstraLuma commented Jul 13, 2019 •
edited
Loading

Fire an event when an asset finishes loading and becomes available.

Depends on #306, #316

@AstraLuma
Initial implementation of event handling.
35b662a 
(Ahhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhh the import loopss!!!!!!)
@AstraLuma AstraLuma requested a review from a team as a code owner July 13, 2019 02:17
@AstraLuma
Copy link
Member Author

AstraLuma commented Jul 13, 2019 •
edited
Loading

This is currently so plagued with import loops that I'm starting to wonder if we should just disallow them altogether.

#304

@AstraLuma AstraLuma mentioned this pull request Jul 14, 2019
Closed
@AstraLuma
Work around 3.6 circular import bug
d4857c6 
Turns out, "import ppb._ as _" with circular imports is bugged on 3.6 in a way that "from ppb import _" isn't.
@AstraLuma
sprites: import Vector from ppb_vector directly
84e201a
@AstraLuma AstraLuma changed the title [WIP] Add AssetLoaded event Add AssetLoaded event Jul 16, 2019
@AstraLuma
Copy link
Member Author

AstraLuma commented Jul 16, 2019 •
edited
Loading

Ok, 3.6 is happier now. I just had to rewrite, like, 2 dozen imports.

(I didn't, actually, but I did for consistency.)

@AstraLuma AstraLuma mentioned this pull request Jul 16, 2019
Merged
pathunstrom
pathunstrom approved these changes Jul 23, 2019
View reviewed changes
Copy link
Collaborator

@pathunstrom pathunstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

bors r+

@pathunstrom pathunstrom added the bors Someone has bors r+ this PR label Jul 23, 2019
@bors
Copy link
Contributor

bors bot commented Jul 23, 2019

Merge conflict (retrying...)

bors bot added a commit that referenced this pull request Jul 23, 2019
@bors @AstraLuma
Merge #315 #328
0ac8d2d 
315: Add AssetLoaded event r=pathunstrom a=astronouth7303

Fire an event when an asset finishes loading and becomes available.

Depends on #306, #316 

328: Manual Testing r=pathunstrom a=astronouth7303

Initial version of manual/visual tests.

Co-authored-by: Jamie Bliss <jamie@ivyleav.es>
@bors
Copy link
Contributor

bors bot commented Jul 23, 2019

Build succeeded

  • docs
  • Linux python:3.6-slim
  • Linux python:3.7-slim
  • macOS PYTHON:3.6.8
  • macOS PYTHON:3.7.2
  • pep517
  • Windows python:3.6-windowsservercore-1809
  • Windows python:3.7-windowsservercore-1809

@bors bors bot merged commit 7411806 into ppb:master Jul 23, 2019
@AstraLuma AstraLuma deleted the assets-events branch May 11, 2020 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pathunstrom pathunstrom pathunstrom approved these changes

Assignees
No one assigned
Labels
bors Someone has bors r+ this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AstraLuma @pathunstrom