Move things, break loops #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: I know this code is all pygame-specific, but the way I figure, separating it out like this should make it easier to bundle it up into |
Closed
|
Ok, I think this is ready to go as soon as #306 merges. |
pathunstrom
requested changes
Jul 14, 2019
| import ppb.events as events | ||
| import ppb.keycodes as keys | ||
| from ppb.systems.base import System | ||
| from ppb.systems.renderer import DEFAULT_RESOLUTION |
There was a problem hiding this comment.
Not blocking this, but we should probably move shared defaults to their own file somewhere.
There was a problem hiding this comment.
Possibly? If we had more than one?
I grouped it like this because resolution felt like a renderer concern, and the renderer is responsible for window management currently?
Merged
|
@pathunstrom can you take a second pass on this? |
bors bot
added a commit
that referenced
this pull request
Jul 18, 2019
316: Move things, break loops r=pathunstrom a=astronouth7303 Grab a u-haul! 🚚 Generally moving things and reducing imports to improve the import loop situation * Break up "the machinery implementing a thing" and "a pile of things that use the thing" * Prefer module imports to individual imports, so any unavoidable loops don't wreck everything. Depends on #306 because I didn't feel like dealing with the merge conflict. No docs changes because this doesn't touch anything publicly documented. Co-authored-by: Jamie Bliss <jamie@ivyleav.es>
Timed out |
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Jul 18, 2019
316: Move things, break loops r=pathunstrom a=astronouth7303 Grab a u-haul! 🚚 Generally moving things and reducing imports to improve the import loop situation * Break up "the machinery implementing a thing" and "a pile of things that use the thing" * Prefer module imports to individual imports, so any unavoidable loops don't wreck everything. Depends on #306 because I didn't feel like dealing with the merge conflict. No docs changes because this doesn't touch anything publicly documented. Co-authored-by: Jamie Bliss <jamie@ivyleav.es>
Timed out |
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Jul 18, 2019
316: Move things, break loops r=pathunstrom a=astronouth7303 Grab a u-haul! 🚚 Generally moving things and reducing imports to improve the import loop situation * Break up "the machinery implementing a thing" and "a pile of things that use the thing" * Prefer module imports to individual imports, so any unavoidable loops don't wreck everything. Depends on #306 because I didn't feel like dealing with the merge conflict. No docs changes because this doesn't touch anything publicly documented. Co-authored-by: Jamie Bliss <jamie@ivyleav.es>
Timed out |
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Jul 18, 2019
316: Move things, break loops r=pathunstrom a=astronouth7303 Grab a u-haul! 🚚 Generally moving things and reducing imports to improve the import loop situation * Break up "the machinery implementing a thing" and "a pile of things that use the thing" * Prefer module imports to individual imports, so any unavoidable loops don't wreck everything. Depends on #306 because I didn't feel like dealing with the merge conflict. No docs changes because this doesn't touch anything publicly documented. Co-authored-by: Jamie Bliss <jamie@ivyleav.es>
Timed out |
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Jul 19, 2019
316: Move things, break loops r=pathunstrom a=astronouth7303 Grab a u-haul! 🚚 Generally moving things and reducing imports to improve the import loop situation * Break up "the machinery implementing a thing" and "a pile of things that use the thing" * Prefer module imports to individual imports, so any unavoidable loops don't wreck everything. Depends on #306 because I didn't feel like dealing with the merge conflict. No docs changes because this doesn't touch anything publicly documented. Co-authored-by: Jamie Bliss <jamie@ivyleav.es>
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grab a u-haul! 🚚
Generally moving things and reducing imports to improve the import loop situation
Depends on #306 because I didn't feel like dealing with the merge conflict.
No docs changes because this doesn't touch anything publicly documented.