Move joystick-axis-to-button simulation out of JoystickHandler
#5278
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow
AndroidJoystickHandler
(coming soon) to reuse this logic without code duplication.Inheritance is not an option as
AndroidInputHandler
is used on Android.This code does look a bit dubious as
JoystickButtonInput.Apply
is called withinJoystickAxisInput.Apply
, but the current order of events is preserved.KeyCombination
does have a similar scroll delta to button conversion, but putting the logic there will break existingJoystickButton.JoystickAxisN
usages.