Add support for playing a per-ruleset sound when switching rulesets #12528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppy
reviewed
Apr 22, 2021
| @@ -54,6 +59,9 @@ private void load() | |||
| } | |||
| } | |||
| }); | |||
|
|
|||
| foreach (var ruleset in Rulesets.AvailableRulesets) | |||
| selectionSamples[ruleset.ShortName] = audio.Samples.Get($"UI/ruleset-select-{ruleset.ShortName}"); | |||
There was a problem hiding this comment.
You mentioned that custom rulesets can also use this, but they won't be able to with this logic as it stands. The resource would need to be read from their storage, not the game's one.
Not sure if this is an issue just yet though. Might be something we add support for in the future.
There was a problem hiding this comment.
Oh, I didn't realise that custom ruleset resources were independent... bad assumption on my behalf about how resources worked then, oops.
There was a problem hiding this comment.
Something similar to CreateIcon() is likely what we want, but I would probably recommend not doing that just yet due to concerns mentioned in #11240.
bdach
reviewed
Apr 22, 2021
peppy
approved these changes
Apr 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I looked at doing this at a
Rulesetlevel alaCreateIcon(), but instantiating aSamplethere seemed... not ideal? So I went with this approach instead.Samples for the base rulesets are added in ppy/osu-resources#122 which will be played when the ruleset is selected (via the Toolbar).