Separate slider ball and followcircle skinnables into default/legacy classes #18945
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #14832 based on comments from #18795
The original PR was too ambitious. As mentioned, the changes should have been more granular. This is the first part of the original PR and aims to make improvements to the project's file structure, which is necessary to implement the slider anim changes. However, keeping with the idea of granularity, this PR is meant to be treated mostly individually, as this PR is intended to be beneficial on its own, whether or not the slider anim changes are accepted.
Summary
Default
andLegacy
classesSliderBall
into newDrawableSliderBall
classfullSizeFollowCircle
tofollowCircleReceptor
Rationale
Default
andLegacy
classes:DrawableSliderBall
class:Skinning
namespace should pertain to visuals, not to actual game logic (i.e. tracking, ball movement)Default
andLegacy
(without duplicating an ungodly amount of code)fullSizeFollowCircle
tofollowCircleReceptor
:DrawableHitCircle
names its own hitbox