Fix replays showing incorrect star difficulty on load #18984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenzibyte
changed the title
peppy
reviewed
Jul 2, 2022
| starDifficulty.ValueChanged += d => | ||
| { | ||
| Debug.Assert(d.NewValue != null); | ||
| starDifficulty.ValueChanged += d => |
There was a problem hiding this comment.
Is there much reason to keep the above Show logic rather than use BindValueChanged(...,true)? Second is preferable I think.
There was a problem hiding this comment.
Haven't done that because the initial logic above shows star rating display immediately, but if the calculation takes longer, it fades in smoothly once it's ready instead. Could merge together and use d.NewValue == d.OldValue to decide the transition, but not sure that reads better.
There was a problem hiding this comment.
okay, let's go with it then. didn't see the initial Alpha=0.
peppy
approved these changes
Jul 2, 2022
This was referenced Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replays update mods bindable with score mods on
OnEntering, which can happen afterBeatmapMetadataDisplaydisplays the current (no score mods) star rating.Alternative fix would be to update the mods bindable much earlier (at BDL or load complete), but going with a more local fix for now.