Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use remote registry API [prax] #100

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Use remote registry API [prax] #100

merged 1 commit into from
Jul 15, 2024

Conversation

grod220
Copy link
Contributor

@grod220 grod220 commented Jul 15, 2024

Follow up after penumbra-zone/web#1472

Updates packages so that Prax can use the new registry API that makes frontend + rpc list dynamic (versus bundled). See explanation in previous PR.

Copy link

changeset-bot bot commented Jul 15, 2024

🦋 Changeset detected

Latest commit: 1761dad

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@repo/context Minor
chrome-extension Minor
@repo/ui Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@grod220 grod220 Jul 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See loading indicator:
Screenshot 2024-07-15 at 10 11 17 AM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grod220 grod220 requested a review from a team July 15, 2024 08:55
Copy link
Contributor

@Valentine1898 Valentine1898 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@grod220 grod220 merged commit f22eef4 into main Jul 15, 2024
3 checks passed
@grod220 grod220 deleted the async-registry branch July 15, 2024 09:17
@grod220 grod220 self-assigned this Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants