Use remote registry API #1472
Use remote registry API #1472
Conversation
🦋 Changeset detectedLatest commit: 056153a The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| ]; | ||
|
|
||
| const getMetadata: MetadataFetchFn = async ({ assetId }) => { | ||
| const feeAssetId = assetId ? assetId : new ChainRegistryClient().bundled.globals().stakingAssetId; |
There was a problem hiding this comment.
Given stakingAssetId should never change, in this PR I often grab this from the bundle
|
|
||
| export enum TxDetailsTab { | ||
| PUBLIC = 'public', | ||
| PRIVATE = 'private', | ||
| RECIEVER = 'reciever', | ||
| RECEIVER = 'receiver', |
| <ActionViewComponent av={av} feeValueView={feeValueView} key={i} /> | ||
| ))} | ||
| </ViewSection> | ||
| <ViewSection heading='Parameters'> | ||
| <ViewBox | ||
| label='Transaction Fee' | ||
| visibleContent={ | ||
| <div className='font-mono'> | ||
| <div className='flex items-center gap-2'> |
No tx blocking would occur. During say a tx approval, it requests metadata from the local view service. If for some reason the service worker wasn't able to reach github, the registry may not be populated and the fee token would simply display as an unknown asset. The ibc page, however, does rely upon the remote registry to know what ibc channels are available.
Once during service worker instantiation and once on the ibc page |
Since prax-wallet/registry#29 minifront has been using the bundled registry in the npm package. While this has given us consistency of schema and non-reliance upon github, users are feeling the pains of not having a dynamically updated registry source (users not seeing updated icons, using ibc connections would have to wait on chrome store review, etc).
This PR utilizes v10 of the registry which has remote methods that call github for the latest registry: prax-wallet/registry#57.