Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Svg attributes improvements #3615

Merged
merged 1 commit into from
Jul 15, 2022
Merged

Svg attributes improvements #3615

merged 1 commit into from
Jul 15, 2022

Conversation

iminside
Copy link
Contributor

@iminside iminside commented Jul 13, 2022 •
edited
Loading

Hi, guys!

Added support for properties:

  • image-rendering
  • letter-spacing
  • lighting-color
  • pointer-events
  • transform-origin

Property conversion fixed:

  • color-interpolation-filters
  • font-size-adjust
  • glyph-orientation-horizontal
  • glyph-orientation-vertical
  • horiz-adv-x
  • horiz-origin-x
  • units-per-em
  • vert-adv-y
  • vert-origin-x
  • vert-origin-y

Old behavior:

  • colorInterpolationFilters -> color-interpolationfilters
  • fontSizeAdjust -> font-sizeadjust
  • glyphOrientationHorizontal -> glyph-orientationhorizontal
  • glyphOrientationVertical -> glyph-orientationvertical
  • horizAdvX -> horiz-advx
  • horizOriginX -> horiz-originx
  • unitsPerEm -> units-perem
  • vertAdvY -> vert-advy
  • vertOriginX -> vert-originx
  • vertOriginY -> vert-originy

New (correct) behavior:

  • colorInterpolationFilters -> color-interpolation-filters
  • fontSizeAdjust -> font-size-adjust
  • glyphOrientationHorizontal -> glyph-orientation-horizontal
  • glyphOrientationVertical -> glyph-orientation-vertical
  • horizAdvX -> horiz-adv-x
  • horizOriginX -> horiz-origin-x
  • unitsPerEm -> units-per-em
  • vertAdvY -> vert-adv-y
  • vertOriginX -> vert-origin-x
  • vertOriginY -> vert-origin-y

Added behavior validation tests

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.454% when pulling 86aee53 on iminside:svg-improvements into dbe0fa8 on preactjs:master.

@iminside iminside changed the title Svg dashed props conversion improvements Svg props improvements Jul 13, 2022
@iminside iminside changed the title Svg props improvements Svg attributes improvements Jul 13, 2022
JoviDeCroock
JoviDeCroock approved these changes Jul 15, 2022
View reviewed changes
Copy link
Member

@JoviDeCroock JoviDeCroock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thank you!

@JoviDeCroock JoviDeCroock merged commit e960162 into preactjs:master Jul 15, 2022
This was referenced Aug 4, 2022
Closed
Merged
JoviDeCroock added a commit that referenced this pull request Sep 2, 2022
@JoviDeCroock
backport #3615
0c2d9ee
JoviDeCroock added a commit that referenced this pull request Sep 2, 2022
@JoviDeCroock
Backports x (#3707)
aa8d57b 
* backport #3615

* backport #3633

* backport #3643

* backport #3655

* backport #3663

* backport #3690

* backport useState optim
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iminside @coveralls @JoviDeCroock