Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for undefined __hooks in afterpaint #3643

Merged
merged 1 commit into from
Aug 3, 2022

Conversation

JoviDeCroock
Copy link
Member

Fixes #3642

During suspensions we reset the hooks state https://github.com/preactjs/preact/blob/master/compat/src/suspense.js#L51 which could turn out problematic if an afterpaint is queued 😅

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.458% when pulling 1658d43 on fix-undefined-suspense into e201caf on master.

@github-actions
Copy link

github-actions bot commented Aug 2, 2022

Size Change: +10 B (0%)

Total Size: 43.5 kB

Filename Size Change
hooks/dist/hooks.js 1.31 kB +2 B (0%)
hooks/dist/hooks.module.js 1.34 kB +4 B (0%)
hooks/dist/hooks.umd.js 1.4 kB +4 B (0%)
ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.67 kB 0 B
compat/dist/compat.module.js 3.65 kB 0 B
compat/dist/compat.umd.js 3.73 kB 0 B
debug/dist/debug.js 3 kB 0 B
debug/dist/debug.module.js 3 kB 0 B
debug/dist/debug.umd.js 3.08 kB 0 B
devtools/dist/devtools.js 230 B 0 B
devtools/dist/devtools.module.js 238 B 0 B
devtools/dist/devtools.umd.js 305 B 0 B
dist/preact.js 4 kB 0 B
dist/preact.min.js 4.03 kB 0 B
dist/preact.module.js 4.02 kB 0 B
dist/preact.umd.js 4.06 kB 0 B
jsx-runtime/dist/jsxRuntime.js 317 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 327 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 395 B 0 B
test-utils/dist/testUtils.js 444 B 0 B
test-utils/dist/testUtils.module.js 444 B 0 B
test-utils/dist/testUtils.umd.js 521 B 0 B

compressed-size-action

Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@marvinhagemeister marvinhagemeister merged commit f4bd535 into master Aug 3, 2022
@marvinhagemeister marvinhagemeister deleted the fix-undefined-suspense branch August 3, 2022 19:11
JoviDeCroock added a commit that referenced this pull request Sep 2, 2022
JoviDeCroock added a commit that referenced this pull request Sep 2, 2022
* backport #3615

* backport #3633

* backport #3643

* backport #3655

* backport #3663

* backport #3690

* backport useState optim
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot set properties of null (setting '__h') error when suspending the entire app
3 participants