Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add types of PictureInPictureEvent #4020

Merged
merged 5 commits into from
May 20, 2023
Merged

Add types of PictureInPictureEvent #4020

merged 5 commits into from
May 20, 2023

Conversation

shoonia
Copy link
Contributor

@shoonia shoonia commented May 20, 2023 •
edited
Loading

The PictureInPictureEvent interface represents picture-in-picture-related events, including

@shoonia
Copy link
Contributor Author

shoonia commented May 20, 2023

TypeScript dom lib include PictureInPictureEvent interface
https://github.com/microsoft/TypeScript/blob/master/src/lib/dom.generated.d.ts#LL17374C1-L17383C3

@JoviDeCroock
Copy link
Member

@shoonia you might need to upgrade our TypeScript version to 4.9 for PictureInPictureEvent

@coveralls
Copy link

Coverage Status

Coverage: 99.705%. Remained the same when pulling 3a3ca0d on shoonia:picture-in-picture-event into d84ddf3 on preactjs:master.

@JoviDeCroock JoviDeCroock merged commit 87024e8 into preactjs:master May 20, 2023
@shoonia
Copy link
Contributor Author

shoonia commented May 20, 2023

Thanks @JoviDeCroock

@JoviDeCroock JoviDeCroock mentioned this pull request May 20, 2023
Merged
@shoonia shoonia deleted the picture-in-picture-event branch May 20, 2023 14:20
@JoviDeCroock
Copy link
Member

JoviDeCroock commented May 20, 2023 •
edited
Loading

@shoonia no problem, thank you for the PR! I will try to get this out tomorrow with #4011 don't have a lot of time left today

@rpendyala2 rpendyala2 mentioned this pull request May 22, 2023
Closed
JoviDeCroock added a commit that referenced this pull request Jan 24, 2024
@JoviDeCroock
backport #4020
bc18674
JoviDeCroock added a commit that referenced this pull request Jan 24, 2024
@JoviDeCroock
Backport 10.15 release line (#4265)
255d011 
* backport #4016

* backport #3996

* backport #4017

* backport #4019

* backport #4020

* backport #4026

* backport #4028
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shoonia @JoviDeCroock @coveralls