Adds missing Context and Dispatch types to compat #4028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scott-Fischer
changed the title
rschristian
reviewed
May 24, 2023
compat/src/index.d.ts
Outdated
| @@ -30,6 +30,7 @@ declare namespace React { | |||
| export import useReducer = _hooks.useReducer; | |||
| export import useRef = _hooks.useRef; | |||
| export import useState = _hooks.useState; | |||
| export type Dispatch<A> = (value: A) => void; | |||
There was a problem hiding this comment.
Suggested change
| export type Dispatch<A> = (value: A) => void; | |
| export type Dispatch<A> = (action: A) => void; |
Might be worth extracting to core hook's types for reuse in submodules, not sure. We do use it in a few different places.
There was a problem hiding this comment.
@rschristian Do you mean define the type in ./src/index.d.ts as part of preact's namespace and re-export in the compat types via ./compat/src/index.d.ts?
There was a problem hiding this comment.
Whoops, sorry. Not to core, but to /hooks/src/index.d.ts, as it can be used in useReducer's types quite nicely and re-exported through compat.
There was a problem hiding this comment.
Okay sounds good. I'm making this change now then will mark this as ready for review.
Co-authored-by: Ryan Christian <33403762+rschristian@users.noreply.github.com>
Merged
Scott-Fischer
changed the title
JoviDeCroock
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two missing types to the exported React namespace in compat.
Closes #4027