Skip to content

Commit

Permalink
QuantumBidAdapter usersync bugfix (#2700)
Browse files Browse the repository at this point in the history
* quantumBidAdapter initial commit

* eslint errors fixed

* updating quantumBidAdapter for reviews, fixed tests to work with native

* set new prebid location for testing and some fixing

* added supportedMediaTypes

* Tests fixed

* Fixed issues with image assets. Tested with the example provided

* Size and tests fixed

* Modify tests

* hello world revert changes

* package-lock reverted

* hello world reverted CRLF/LF Conversion

* hello world reverted LF/CRLF Conversion

* hello world reverted

* hello world reverted

* hello world reverted

* removed hardcoded bid sizes

* GDPR integration

* GDPR support - change quantx_gdpr to (0,1) values accepted

* restored package-lock

* GDPR tests

* GDPR tests fixed

* Send width/height with native assets

* Fixed native images bug

* usersync bugfixed

* usersync bugfixed

* usersync bugfixed

* send user sync pixels as images all the time
  • Loading branch information
sami-elasticad authored and jsnellbaker committed Jun 18, 2018
1 parent 2c19032 commit 429d5b4
Showing 1 changed file with 13 additions and 15 deletions.
28 changes: 13 additions & 15 deletions modules/quantumBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -297,23 +297,21 @@ export const spec = {
* Register the user sync pixels which should be dropped after the auction.
*
* @param {SyncOptions} syncOptions Which user syncs are allowed?
* @param {ServerResponse[]} serverResponses List of server's responses.
* @param {ServerResponse} serverResponse A successful response from the server
* @return {UserSync[]} The user syncs which should be dropped.
*/
getUserSyncs: function (syncOptions, serverResponses) {
const syncs = []
if (syncOptions.iframeEnabled) {
syncs.push({
type: 'iframe',
url: '//acdn.adnxs.com/ib/static/usersync/v3/async_usersync.html'
});
}
if (syncOptions.pixelEnabled && serverResponses.length > 0) {
syncs.push({
type: 'image',
url: serverResponses[0].body.sync[0]
});
}
getUserSyncs: function (syncOptions, serverResponse) {
const syncs = [];
utils._each(serverResponse, function(serverResponse) {
if (serverResponse.body && serverResponse.body.sync) {
utils._each(serverResponse.body.sync, function (pixel) {
syncs.push({
type: 'image',
url: pixel
});
});
}
});
return syncs;
}
}
Expand Down

0 comments on commit 429d5b4

Please sign in to comment.