QuantumBidAdapter usersync bugfix #2700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # integrationExamples/gpt/hello_world.html # modules/quantumBidAdapter.js # package.json # test/spec/modules/quantumBidAdapter_spec.js
|
In the condition at line 305 (and multiple times after) you try to get the serverResponses.body property value. serverResponses seems to be an array so you cannot read the body property this way. You should loop through all elements in serverResponses |
|
Hi @malves our ssp responds all the time only with one element not with an array. because of that we don't loop the response body. |
jsnellbaker
reviewed
Jun 18, 2018
There was a problem hiding this comment.
Hi @sami-elasticad,
I had a question regards to the changes; please see the note in-line below.
Additionally, when I tested the iframe userSync pixels I saw a pair of warning messages in the browser console related to the pixels. Below is a copy of the messages:
Resource interpreted as Document but transferred with MIME type image/gif: "http://match.adsrvr.org/track/cmb/generic?ttd_pid=s6e8ued&ttd_tpi=1".
Resource interpreted as Document but transferred with MIME type image/gif: "http://s.sspqns.com/sync?tp_id=28&tp_uid=e3XuIlDznIWDzTooVA5HhRCku6G4ped2t-VRqBewJ-Y%3D".
It seems like the URLs still executed per the Network tab, but I wanted to bring it to your attention.
modules/quantumBidAdapter.js
Outdated
| const syncs = []; | ||
| utils._each(serverResponse, function(serverResponse) { | ||
| if (serverResponse.body && serverResponse.body.sync) { | ||
| const syncType = syncOptions.pixelEnabled ? 'image' : 'iframe'; |
There was a problem hiding this comment.
To clarify the intent here - do you want to only use one type of pixel per auction?
Further, the userSync feature defaults the pixelEnabled field to true and the iframe pixels are opt-in via the config. So your iframe pixels will only drop with specific config options; ie
userSync: {
pixelEnabled: false,
iframeEnabled: true
}
My assumption is this would create a heavier bias towards image-based pixels. Is that a concern?
There was a problem hiding this comment.
Hi. Thank you for your review. From our side all sync pixels are images. I will modify to send all the time 'image' type.
jsnellbaker
approved these changes
Jun 18, 2018
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
* quantumBidAdapter initial commit * eslint errors fixed * updating quantumBidAdapter for reviews, fixed tests to work with native * set new prebid location for testing and some fixing * added supportedMediaTypes * Tests fixed * Fixed issues with image assets. Tested with the example provided * Size and tests fixed * Modify tests * hello world revert changes * package-lock reverted * hello world reverted CRLF/LF Conversion * hello world reverted LF/CRLF Conversion * hello world reverted * hello world reverted * hello world reverted * removed hardcoded bid sizes * GDPR integration * GDPR support - change quantx_gdpr to (0,1) values accepted * restored package-lock * GDPR tests * GDPR tests fixed * Send width/height with native assets * Fixed native images bug * usersync bugfixed * usersync bugfixed * usersync bugfixed * send user sync pixels as images all the time
florevallatmrf
pushed a commit
to Marfeel/Prebid.js
that referenced
this pull request
Sep 6, 2018
* quantumBidAdapter initial commit * eslint errors fixed * updating quantumBidAdapter for reviews, fixed tests to work with native * set new prebid location for testing and some fixing * added supportedMediaTypes * Tests fixed * Fixed issues with image assets. Tested with the example provided * Size and tests fixed * Modify tests * hello world revert changes * package-lock reverted * hello world reverted CRLF/LF Conversion * hello world reverted LF/CRLF Conversion * hello world reverted * hello world reverted * hello world reverted * removed hardcoded bid sizes * GDPR integration * GDPR support - change quantx_gdpr to (0,1) values accepted * restored package-lock * GDPR tests * GDPR tests fixed * Send width/height with native assets * Fixed native images bug * usersync bugfixed * usersync bugfixed * usersync bugfixed * send user sync pixels as images all the time
StefanWallin
pushed a commit
to mittmedia/Prebid.js
that referenced
this pull request
Sep 28, 2018
* quantumBidAdapter initial commit * eslint errors fixed * updating quantumBidAdapter for reviews, fixed tests to work with native * set new prebid location for testing and some fixing * added supportedMediaTypes * Tests fixed * Fixed issues with image assets. Tested with the example provided * Size and tests fixed * Modify tests * hello world revert changes * package-lock reverted * hello world reverted CRLF/LF Conversion * hello world reverted LF/CRLF Conversion * hello world reverted * hello world reverted * hello world reverted * removed hardcoded bid sizes * GDPR integration * GDPR support - change quantx_gdpr to (0,1) values accepted * restored package-lock * GDPR tests * GDPR tests fixed * Send width/height with native assets * Fixed native images bug * usersync bugfixed * usersync bugfixed * usersync bugfixed * send user sync pixels as images all the time
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
* quantumBidAdapter initial commit * eslint errors fixed * updating quantumBidAdapter for reviews, fixed tests to work with native * set new prebid location for testing and some fixing * added supportedMediaTypes * Tests fixed * Fixed issues with image assets. Tested with the example provided * Size and tests fixed * Modify tests * hello world revert changes * package-lock reverted * hello world reverted CRLF/LF Conversion * hello world reverted LF/CRLF Conversion * hello world reverted * hello world reverted * hello world reverted * removed hardcoded bid sizes * GDPR integration * GDPR support - change quantx_gdpr to (0,1) values accepted * restored package-lock * GDPR tests * GDPR tests fixed * Send width/height with native assets * Fixed native images bug * usersync bugfixed * usersync bugfixed * usersync bugfixed * send user sync pixels as images all the time
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
* quantumBidAdapter initial commit * eslint errors fixed * updating quantumBidAdapter for reviews, fixed tests to work with native * set new prebid location for testing and some fixing * added supportedMediaTypes * Tests fixed * Fixed issues with image assets. Tested with the example provided * Size and tests fixed * Modify tests * hello world revert changes * package-lock reverted * hello world reverted CRLF/LF Conversion * hello world reverted LF/CRLF Conversion * hello world reverted * hello world reverted * hello world reverted * removed hardcoded bid sizes * GDPR integration * GDPR support - change quantx_gdpr to (0,1) values accepted * restored package-lock * GDPR tests * GDPR tests fixed * Send width/height with native assets * Fixed native images bug * usersync bugfixed * usersync bugfixed * usersync bugfixed * send user sync pixels as images all the time
AlessandroDG
pushed a commit
to simplaex/Prebid.js
that referenced
this pull request
Mar 26, 2019
* quantumBidAdapter initial commit * eslint errors fixed * updating quantumBidAdapter for reviews, fixed tests to work with native * set new prebid location for testing and some fixing * added supportedMediaTypes * Tests fixed * Fixed issues with image assets. Tested with the example provided * Size and tests fixed * Modify tests * hello world revert changes * package-lock reverted * hello world reverted CRLF/LF Conversion * hello world reverted LF/CRLF Conversion * hello world reverted * hello world reverted * hello world reverted * removed hardcoded bid sizes * GDPR integration * GDPR support - change quantx_gdpr to (0,1) values accepted * restored package-lock * GDPR tests * GDPR tests fixed * Send width/height with native assets * Fixed native images bug * usersync bugfixed * usersync bugfixed * usersync bugfixed * send user sync pixels as images all the time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix
Feature
New bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
contact email of the adapter’s maintainer
official adapter submission