Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuantumBidAdapter usersync bugfix #2700

Merged
merged 35 commits into from
Jun 18, 2018
Merged

QuantumBidAdapter usersync bugfix #2700

Changes from 34 commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
238ab74
quantumBidAdapter initial commit
Jan 18, 2018
b18c512
eslint errors fixed
Jan 19, 2018
c9136b8
Merge remote-tracking branch 'upstream/master'
Feb 14, 2018
56068a5
updating quantumBidAdapter for reviews, fixed tests to work with native
Feb 14, 2018
d24543e
set new prebid location for testing and some fixing
Feb 14, 2018
b5ad2b4
Merge remote-tracking branch 'remotes/upstream/master'
Feb 19, 2018
0a69792
added supportedMediaTypes
Feb 19, 2018
535e20d
Tests fixed
Feb 19, 2018
12f95cb
Fixed issues with image assets. Tested with the example provided
Feb 21, 2018
d655ebb
Size and tests fixed
photonx Apr 16, 2018
5a96550
Merge remote-tracking branch 'upstream/master'
photonx Apr 16, 2018
d99806e
Modify tests
photonx Apr 16, 2018
6f8fe02
hello world revert changes
sami-elasticad Apr 17, 2018
afa6cb2
Merge remote-tracking branch 'upstream/master'
sami-elasticad Apr 17, 2018
9b59f42
package-lock reverted
sami-elasticad Apr 17, 2018
e028cf6
hello world reverted CRLF/LF Conversion
sami-elasticad Apr 17, 2018
aed0363
hello world reverted LF/CRLF Conversion
sami-elasticad Apr 17, 2018
9c2d313
hello world reverted
sami-elasticad Apr 17, 2018
2ecd6d2
hello world reverted
sami-elasticad Apr 17, 2018
769eb9f
hello world reverted
sami-elasticad Apr 17, 2018
04e13ae
removed hardcoded bid sizes
sami-elasticad Apr 23, 2018
afdf32e
Merge remote-tracking branch 'upstream/master'
sami-elasticad May 24, 2018
0022170
GDPR integration
sami-elasticad May 25, 2018
dede438
Merge remote-tracking branch 'upstream/master'
sami-elasticad May 25, 2018
071a57a
GDPR support - change quantx_gdpr to (0,1) values accepted
sami-elasticad May 25, 2018
5ec4de6
restored package-lock
sami-elasticad May 30, 2018
10a0cf3
GDPR tests
sami-elasticad May 30, 2018
68282c5
GDPR tests fixed
sami-elasticad May 30, 2018
2b30f97
Send width/height with native assets
sami-elasticad May 30, 2018
7345b5e
Merge remote-tracking branch 'upstream/master'
sami-elasticad Jun 5, 2018
3e856e1
Fixed native images bug
sami-elasticad Jun 5, 2018
373fdff
usersync bugfixed
sami-elasticad Jun 8, 2018
b11df6d
usersync bugfixed
sami-elasticad Jun 14, 2018
cdf5297
usersync bugfixed
sami-elasticad Jun 15, 2018
6408074
send user sync pixels as images all the time
sami-elasticad Jun 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 20 additions & 21 deletions modules/quantumBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,19 +251,19 @@ export const spec = {
break;
case 2:
native.icon = {
url: asset['img'],
width: asset['w'],
height: asset['h']
url: asset['img']['url'],
width: asset['img']['w'],
height: asset['img']['h']
};
break;
case 3:
native.body = asset['data']['value'];
break;
case 4:
native.image = {
url: asset['img'],
width: asset['w'],
height: asset['h']
url: asset['img']['url'],
width: asset['img']['w'],
height: asset['img']['h']
};
break;
case 10:
Expand Down Expand Up @@ -297,23 +297,22 @@ export const spec = {
* Register the user sync pixels which should be dropped after the auction.
*
* @param {SyncOptions} syncOptions Which user syncs are allowed?
* @param {ServerResponse[]} serverResponses List of server's responses.
* @param {ServerResponse} serverResponse A successful response from the server
* @return {UserSync[]} The user syncs which should be dropped.
*/
getUserSyncs: function (syncOptions, serverResponses) {
const syncs = []
if (syncOptions.iframeEnabled) {
syncs.push({
type: 'iframe',
url: '//acdn.adnxs.com/ib/static/usersync/v3/async_usersync.html'
});
}
if (syncOptions.pixelEnabled && serverResponses.length > 0) {
syncs.push({
type: 'image',
url: serverResponses[0].body.sync[0]
});
}
getUserSyncs: function (syncOptions, serverResponse) {
const syncs = [];
utils._each(serverResponse, function(serverResponse) {
if (serverResponse.body && serverResponse.body.sync) {
const syncType = syncOptions.pixelEnabled ? 'image' : 'iframe';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To clarify the intent here - do you want to only use one type of pixel per auction?

Further, the userSync feature defaults the pixelEnabled field to true and the iframe pixels are opt-in via the config. So your iframe pixels will only drop with specific config options; ie

userSync: {
  pixelEnabled: false,
  iframeEnabled: true
}

My assumption is this would create a heavier bias towards image-based pixels. Is that a concern?

Copy link
Contributor Author

@sami-elasticad sami-elasticad Jun 18, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. Thank you for your review. From our side all sync pixels are images. I will modify to send all the time 'image' type.

utils._each(serverResponse.body.sync, function (pixel) {
syncs.push({
type: syncType,
url: pixel
});
});
}
});
return syncs;
}
}
Expand Down