Skip to content

Commit

Permalink
33Across: Complete user sync implementation (#2334)
Browse files Browse the repository at this point in the history
* Adding 33across adapter

* Updated per code review from Prebid. See #1805 (review)

* Added support for test bid and crid.

* Removed ability to set test url via params

* Incorporated changes requested in #1855 to fix usage of deprecated method

* Reverted hack to karma conf maker to make unit tests pass with --file option

* Enabling POST withCredentials to send userSync cookies
  • Loading branch information
curlyblueeagle authored and jaiminpanchal27 committed Apr 12, 2018
1 parent 95bd54d commit 9303d57
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion modules/33acrossBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ function _createServerRequest(bidRequest) {
*/
const options = {
contentType: 'application/json',
withCredentials: false
withCredentials: true
};
// Allow the ability to configure the HB endpoint for testing purposes.
const ttxSettings = config.getConfig('ttxSettings');
Expand Down
6 changes: 3 additions & 3 deletions test/spec/modules/33acrossBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ describe('33acrossBidAdapter:', function () {
'data': JSON.stringify(ttxRequest),
'options': {
'contentType': 'application/json',
'withCredentials': false
'withCredentials': true
}
}
const builtServerRequests = buildRequests(this.bidRequests);
Expand Down Expand Up @@ -194,7 +194,7 @@ describe('33acrossBidAdapter:', function () {
data: JSON.stringify(ttxRequest),
options: {
contentType: 'application/json',
withCredentials: false
withCredentials: true
}
};

Expand Down Expand Up @@ -244,7 +244,7 @@ describe('33acrossBidAdapter:', function () {
data: JSON.stringify(ttxRequest),
options: {
contentType: 'application/json',
withCredentials: false
withCredentials: true
}
};

Expand Down

0 comments on commit 9303d57

Please sign in to comment.