Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding 33Across adapter #1805

Merged
merged 2 commits into from
Nov 9, 2017
Merged

Adding 33Across adapter #1805

merged 2 commits into from
Nov 9, 2017

Conversation

curlyblueeagle
Copy link
Contributor

@curlyblueeagle curlyblueeagle commented Nov 7, 2017

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other

Description of change

Add new bidder adapter for 33Across

  • test parameters for validating bids
    In order to receive bids please map localhost to (any) test domain. Also update prebid config section as follows:
<--! Prebid Config section >
<script> 
    var PREBID_TIMEOUT = 700;
    var adUnits = [
    {
        code: 'div-gpt-ad-1460505748561-0',
        sizes: [
            [300, 250], 
            [728, 90]
        ],     
        bids: [{
            bidder: '33across',
            params: {
            site: {
                id: 'aRlI5W_9yr5jkxacwqm_6r',
                page: "http://thinkbabynames.com/baby-mcbabyface",
                ext: {
                    ttx: {
                        ssp_configs: [
                            {
                            "name": "index",
                            "enabled": false
                            },
                            {
                            "name": "rubicon",
                            "enabled": true
                            },
                            {
                            "name": "33xchange",
                            "enabled": false
                            }
                        ]
                    }
                }
            },
            productId: 'infeed'
        }
        }]
    }
    ];
    
    var pbjs = pbjs || {};
    pbjs.que = pbjs.que || [];

    // Adjust bid CPM to ensure it wins the auction (USED ONLY FOR TESTING). Need to do this since test bids have too low a CPM
    pbjs.bidderSettings = {
      '33across': {
        bidCpmAdjustment : function(bidCpm, bid){
          // adjust the bid in real time before the auction takes place, only do so for valid bids ignore no bids
          if (bid.w !== 0 && bid.h !== 0 && bidCpm !== 0) {
            return bidCpm + 0.50;
          }
        }
      }
    };
  </script>
  <!-- End Prebid Config section>

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
    aparna.hegde@33across.com
  • official adapter submission

Other information

@curlyblueeagle curlyblueeagle changed the title Adding 33across adapter Adding 33Across adapter Nov 7, 2017
Copy link
Collaborator

@jaiminpanchal27 jaiminpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@curlyblueeagle Awesome code.
Minor change needed.
Thanks

siteId: SITE_ID,
productId: PRODUCT_ID
},
placementCode: 'div-id',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In 1.0 we are going to rename placementCode to adUnitCode. Please update

@ndhimehta ndhimehta added the ready label Nov 8, 2017
@curlyblueeagle
Copy link
Contributor Author

@jaiminpanchal27 Thanks. I have made the changes requested. Not sure why my update breaks the test for another adapter. Please let me know if you need anything from me.

@jaiminpanchal27 jaiminpanchal27 merged commit 1895cb3 into prebid:master Nov 9, 2017
vzhukovsky added a commit to aol/Prebid.js that referenced this pull request Dec 28, 2017
….33.0 to aolgithub-master

* commit '3e9756098bb20ecbe0314f16eed5298c5675b24c': (32 commits)
  Wrapped content type in options object.
  Added partners ids.
  Added changelog entry.
  Prebid 0.33.0 Release
  Update AOL adapter for v1.0  (prebid#1693)
  Sovrn 1.0 compliance (prebid#1796)
  Platform.io Bidder Adapter update (prebid#1817)
  Drop non-video bidders from video ad units (prebid#1815)
  Update renderAd to replace ${AUCTION_PRICE} in adUrl (prebid#1795)
  Pulsepoint adapter: fixing bid rejection due to missing mandatory bid params. (prebid#1823)
  Remove require.ensure entirely (prebid#1816)
  Add custom keyword support for pbs bid adapter (prebid#1763)
  OpenX Video Adapter update to Prebid v1.0 (prebid#1724)
  Fix test that hard-coded pbjs global. (prebid#1786)
  Update Pollux Adapter to v1.0 (prebid#1694)
  PubMatic adapter (prebid#1707)
  Added sizes to Rubicon Adapter (prebid#1818)
  jsonpFunction name should match the namespace (prebid#1785)
  Adding 33Across adapter (prebid#1805)
  Unit test fix (prebid#1812)
  ...
matthewlane pushed a commit that referenced this pull request Feb 6, 2018
* Adding 33across adapter

* Updated per code review from Prebid. See #1805 (review)

* Added support for test bid and crid.

* Removed ability to set test url via params

* Incorporated changes requested in #1855 to fix usage of deprecated method
matthewlane pushed a commit that referenced this pull request Mar 6, 2018
* Adding 33across adapter

* Updated per code review from Prebid. See #1805 (review)

* Added support for test bid and crid.

* Removed ability to set test url via params

* Incorporated changes requested in #1855 to fix usage of deprecated method

* Reverted hack to karma conf maker to make unit tests pass with --file option
jaiminpanchal27 pushed a commit that referenced this pull request Apr 12, 2018
* Adding 33across adapter

* Updated per code review from Prebid. See #1805 (review)

* Added support for test bid and crid.

* Removed ability to set test url via params

* Incorporated changes requested in #1855 to fix usage of deprecated method

* Reverted hack to karma conf maker to make unit tests pass with --file option

* Enabling POST withCredentials to send userSync cookies
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
* Adding 33across adapter

* Updated per code review from Prebid. See prebid#1805 (review)
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
* Adding 33across adapter

* Updated per code review from Prebid. See prebid#1805 (review)

* Added support for test bid and crid.

* Removed ability to set test url via params

* Incorporated changes requested in prebid#1855 to fix usage of deprecated method
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
* Adding 33across adapter

* Updated per code review from Prebid. See prebid#1805 (review)

* Added support for test bid and crid.

* Removed ability to set test url via params

* Incorporated changes requested in prebid#1855 to fix usage of deprecated method

* Reverted hack to karma conf maker to make unit tests pass with --file option
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
* Adding 33across adapter

* Updated per code review from Prebid. See prebid#1805 (review)

* Added support for test bid and crid.

* Removed ability to set test url via params

* Incorporated changes requested in prebid#1855 to fix usage of deprecated method

* Reverted hack to karma conf maker to make unit tests pass with --file option

* Enabling POST withCredentials to send userSync cookies
jsnellbaker pushed a commit that referenced this pull request Jul 26, 2018
* Adding 33across adapter

* Updated per code review from Prebid. See #1805 (review)

* Added support for test bid and crid.

* Removed ability to set test url via params

* Incorporated changes requested in #1855 to fix usage of deprecated method

* Reverted hack to karma conf maker to make unit tests pass with --file option

* Enabling POST withCredentials to send userSync cookies

* Sync based on unique site id

* Store siteID's in module level object instead of config

* Eliminate preflight. Remove test setup in docs

* Added alias for contact mailing list
florevallatmrf pushed a commit to Marfeel/Prebid.js that referenced this pull request Sep 6, 2018
* Adding 33across adapter

* Updated per code review from Prebid. See prebid#1805 (review)

* Added support for test bid and crid.

* Removed ability to set test url via params

* Incorporated changes requested in prebid#1855 to fix usage of deprecated method

* Reverted hack to karma conf maker to make unit tests pass with --file option

* Enabling POST withCredentials to send userSync cookies

* Sync based on unique site id

* Store siteID's in module level object instead of config

* Eliminate preflight. Remove test setup in docs

* Added alias for contact mailing list
StefanWallin pushed a commit to mittmedia/Prebid.js that referenced this pull request Sep 28, 2018
* Adding 33across adapter

* Updated per code review from Prebid. See prebid#1805 (review)

* Added support for test bid and crid.

* Removed ability to set test url via params

* Incorporated changes requested in prebid#1855 to fix usage of deprecated method

* Reverted hack to karma conf maker to make unit tests pass with --file option

* Enabling POST withCredentials to send userSync cookies

* Sync based on unique site id

* Store siteID's in module level object instead of config

* Eliminate preflight. Remove test setup in docs

* Added alias for contact mailing list
ghost pushed a commit to devunrulymedia/Prebid.js that referenced this pull request Jan 30, 2019
* Adding 33across adapter

* Updated per code review from Prebid. See prebid#1805 (review)

* Added support for test bid and crid.

* Removed ability to set test url via params

* Incorporated changes requested in prebid#1855 to fix usage of deprecated method

* Reverted hack to karma conf maker to make unit tests pass with --file option

* Enabling POST withCredentials to send userSync cookies

* Sync based on unique site id

* Store siteID's in module level object instead of config

* Eliminate preflight. Remove test setup in docs

* Added alias for contact mailing list
AlessandroDG pushed a commit to simplaex/Prebid.js that referenced this pull request Mar 26, 2019
* Adding 33across adapter

* Updated per code review from Prebid. See prebid#1805 (review)

* Added support for test bid and crid.

* Removed ability to set test url via params

* Incorporated changes requested in prebid#1855 to fix usage of deprecated method

* Reverted hack to karma conf maker to make unit tests pass with --file option

* Enabling POST withCredentials to send userSync cookies

* Sync based on unique site id

* Store siteID's in module level object instead of config

* Eliminate preflight. Remove test setup in docs

* Added alias for contact mailing list
AlessandroDG pushed a commit to simplaex/Prebid.js that referenced this pull request Mar 26, 2019
* Adding 33across adapter

* Updated per code review from Prebid. See prebid#1805 (review)

* Added support for test bid and crid.

* Removed ability to set test url via params

* Incorporated changes requested in prebid#1855 to fix usage of deprecated method

* Reverted hack to karma conf maker to make unit tests pass with --file option

* Enabling POST withCredentials to send userSync cookies

* Sync based on unique site id

* Store siteID's in module level object instead of config

* Eliminate preflight. Remove test setup in docs

* Added alias for contact mailing list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants