-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding 33Across adapter #1805
Adding 33Across adapter #1805
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@curlyblueeagle Awesome code.
Minor change needed.
Thanks
siteId: SITE_ID, | ||
productId: PRODUCT_ID | ||
}, | ||
placementCode: 'div-id', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In 1.0 we are going to rename placementCode
to adUnitCode
. Please update
@jaiminpanchal27 Thanks. I have made the changes requested. Not sure why my update breaks the test for another adapter. Please let me know if you need anything from me. |
….33.0 to aolgithub-master * commit '3e9756098bb20ecbe0314f16eed5298c5675b24c': (32 commits) Wrapped content type in options object. Added partners ids. Added changelog entry. Prebid 0.33.0 Release Update AOL adapter for v1.0 (prebid#1693) Sovrn 1.0 compliance (prebid#1796) Platform.io Bidder Adapter update (prebid#1817) Drop non-video bidders from video ad units (prebid#1815) Update renderAd to replace ${AUCTION_PRICE} in adUrl (prebid#1795) Pulsepoint adapter: fixing bid rejection due to missing mandatory bid params. (prebid#1823) Remove require.ensure entirely (prebid#1816) Add custom keyword support for pbs bid adapter (prebid#1763) OpenX Video Adapter update to Prebid v1.0 (prebid#1724) Fix test that hard-coded pbjs global. (prebid#1786) Update Pollux Adapter to v1.0 (prebid#1694) PubMatic adapter (prebid#1707) Added sizes to Rubicon Adapter (prebid#1818) jsonpFunction name should match the namespace (prebid#1785) Adding 33Across adapter (prebid#1805) Unit test fix (prebid#1812) ...
* Adding 33across adapter * Updated per code review from Prebid. See #1805 (review) * Added support for test bid and crid. * Removed ability to set test url via params * Incorporated changes requested in #1855 to fix usage of deprecated method
* Adding 33across adapter * Updated per code review from Prebid. See #1805 (review) * Added support for test bid and crid. * Removed ability to set test url via params * Incorporated changes requested in #1855 to fix usage of deprecated method * Reverted hack to karma conf maker to make unit tests pass with --file option
* Adding 33across adapter * Updated per code review from Prebid. See #1805 (review) * Added support for test bid and crid. * Removed ability to set test url via params * Incorporated changes requested in #1855 to fix usage of deprecated method * Reverted hack to karma conf maker to make unit tests pass with --file option * Enabling POST withCredentials to send userSync cookies
* Adding 33across adapter * Updated per code review from Prebid. See prebid#1805 (review)
* Adding 33across adapter * Updated per code review from Prebid. See prebid#1805 (review) * Added support for test bid and crid. * Removed ability to set test url via params * Incorporated changes requested in prebid#1855 to fix usage of deprecated method
* Adding 33across adapter * Updated per code review from Prebid. See prebid#1805 (review) * Added support for test bid and crid. * Removed ability to set test url via params * Incorporated changes requested in prebid#1855 to fix usage of deprecated method * Reverted hack to karma conf maker to make unit tests pass with --file option
* Adding 33across adapter * Updated per code review from Prebid. See prebid#1805 (review) * Added support for test bid and crid. * Removed ability to set test url via params * Incorporated changes requested in prebid#1855 to fix usage of deprecated method * Reverted hack to karma conf maker to make unit tests pass with --file option * Enabling POST withCredentials to send userSync cookies
* Adding 33across adapter * Updated per code review from Prebid. See #1805 (review) * Added support for test bid and crid. * Removed ability to set test url via params * Incorporated changes requested in #1855 to fix usage of deprecated method * Reverted hack to karma conf maker to make unit tests pass with --file option * Enabling POST withCredentials to send userSync cookies * Sync based on unique site id * Store siteID's in module level object instead of config * Eliminate preflight. Remove test setup in docs * Added alias for contact mailing list
* Adding 33across adapter * Updated per code review from Prebid. See prebid#1805 (review) * Added support for test bid and crid. * Removed ability to set test url via params * Incorporated changes requested in prebid#1855 to fix usage of deprecated method * Reverted hack to karma conf maker to make unit tests pass with --file option * Enabling POST withCredentials to send userSync cookies * Sync based on unique site id * Store siteID's in module level object instead of config * Eliminate preflight. Remove test setup in docs * Added alias for contact mailing list
* Adding 33across adapter * Updated per code review from Prebid. See prebid#1805 (review) * Added support for test bid and crid. * Removed ability to set test url via params * Incorporated changes requested in prebid#1855 to fix usage of deprecated method * Reverted hack to karma conf maker to make unit tests pass with --file option * Enabling POST withCredentials to send userSync cookies * Sync based on unique site id * Store siteID's in module level object instead of config * Eliminate preflight. Remove test setup in docs * Added alias for contact mailing list
* Adding 33across adapter * Updated per code review from Prebid. See prebid#1805 (review) * Added support for test bid and crid. * Removed ability to set test url via params * Incorporated changes requested in prebid#1855 to fix usage of deprecated method * Reverted hack to karma conf maker to make unit tests pass with --file option * Enabling POST withCredentials to send userSync cookies * Sync based on unique site id * Store siteID's in module level object instead of config * Eliminate preflight. Remove test setup in docs * Added alias for contact mailing list
* Adding 33across adapter * Updated per code review from Prebid. See prebid#1805 (review) * Added support for test bid and crid. * Removed ability to set test url via params * Incorporated changes requested in prebid#1855 to fix usage of deprecated method * Reverted hack to karma conf maker to make unit tests pass with --file option * Enabling POST withCredentials to send userSync cookies * Sync based on unique site id * Store siteID's in module level object instead of config * Eliminate preflight. Remove test setup in docs * Added alias for contact mailing list
* Adding 33across adapter * Updated per code review from Prebid. See prebid#1805 (review) * Added support for test bid and crid. * Removed ability to set test url via params * Incorporated changes requested in prebid#1855 to fix usage of deprecated method * Reverted hack to karma conf maker to make unit tests pass with --file option * Enabling POST withCredentials to send userSync cookies * Sync based on unique site id * Store siteID's in module level object instead of config * Eliminate preflight. Remove test setup in docs * Added alias for contact mailing list
Type of change
Description of change
Add new bidder adapter for 33Across
In order to receive bids please map localhost to (any) test domain. Also update prebid config section as follows:
Be sure to test the integration with your adserver using the Hello World sample page.
aparna.hegde@33across.com
Other information