Update Pollux Adapter to v1.0 #1694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added module, test spec and integration example for Pollux Network Bid Adapter
Update Pollux default domain on prebid adapter
On Utils.js make getParameterByName method public
Moved zone_728x90.html to integrationExamples/gpt/pollux_zone_728x90.html; Added bidRequest as second parameter to bidfactory.createBid() on Pollux Bid Adapter; Added more test cases to increase test coverage (at least 85%); Review Ref: - prebid#1431 (review)
- Removed $$PREBID_GLOBAL$$ public vars in unit test; - Moved stubs creation and its restoration to beforeEach and afterEach hooks in unit test; - Exposed polluxHandler method on polluxBidAdapter.
This line was added in prebid#1409, removing this then I'll merge
|
The diff seems to be 0 lines...? Have your changes been accidentally removed? |
|
Yeah @snapwich, sorry about that, created the pull request way too soon :) |
|
@hdjvieira Can you resolve the conflict |
|
@snapwich |
snapwich
requested changes
Nov 7, 2017
modules/polluxBidAdapter.js
Outdated
| */ | ||
| buildRequests: function (validBidRequests) { | ||
| if (!Array.isArray(validBidRequests) || !validBidRequests.length) { | ||
| return {}; |
There was a problem hiding this comment.
This would cause an invalid request to be logged. You should return an empty array instead: []
There was a problem hiding this comment.
@snapwich File changed, please review
Thank you
mkendall07
requested changes
Nov 9, 2017
modules/polluxBidAdapter.js
Outdated
| var bid = serverResponse[b]; | ||
| const bidResponse = { | ||
| requestId: bid.bidId, // not request id, it's bid's id | ||
| bidderCode: spec.code, |
There was a problem hiding this comment.
Please drop bidderCode here. It's not required and in fact breaks adapter aliasing. Thanks sorry for the confusion.
There was a problem hiding this comment.
Will do, but just enlight me here :)
"bidderCode" was a required parameter before, or at least it was in the docs right?
Thanks for your help
There was a problem hiding this comment.
Right on both counts. We have since fixed the documentation to omit that param. Thanks
…75505070 Rmoved parameter bidderCode from bid responses
Parameter serverResponse of method interpretResponse in bid adapter changed from array of bids to an object, where bids are now nested within its parameter body. Plus a refactor of var declaration and log messages.
mkendall07
approved these changes
Nov 10, 2017
Millerrok
pushed a commit
to Vertamedia/Prebid.js
that referenced
this pull request
Nov 21, 2017
* unstream/master: (36 commits) + Add Optimatic Bid Adapter (prebid#1837) Add Bridgewell adapter (prebid#1825) Kumma adapter updated for Prebid 1.0 (prebid#1766) Touchup add bid response (prebid#1822) Fix skipped test (prebid#1836) Added new size in Rubicon pbjs Adapter (prebid#1842) HuddledMasses header bidding adapter (prebid#1806) Increment pre version Prebid 0.33.0 Release Update AOL adapter for v1.0 (prebid#1693) Sovrn 1.0 compliance (prebid#1796) Platform.io Bidder Adapter update (prebid#1817) Drop non-video bidders from video ad units (prebid#1815) Update renderAd to replace ${AUCTION_PRICE} in adUrl (prebid#1795) Pulsepoint adapter: fixing bid rejection due to missing mandatory bid params. (prebid#1823) Remove require.ensure entirely (prebid#1816) Add custom keyword support for pbs bid adapter (prebid#1763) OpenX Video Adapter update to Prebid v1.0 (prebid#1724) Fix test that hard-coded pbjs global. (prebid#1786) Update Pollux Adapter to v1.0 (prebid#1694) ...
vzhukovsky
added a commit
to aol/Prebid.js
that referenced
this pull request
Dec 28, 2017
….33.0 to aolgithub-master * commit '3e9756098bb20ecbe0314f16eed5298c5675b24c': (32 commits) Wrapped content type in options object. Added partners ids. Added changelog entry. Prebid 0.33.0 Release Update AOL adapter for v1.0 (prebid#1693) Sovrn 1.0 compliance (prebid#1796) Platform.io Bidder Adapter update (prebid#1817) Drop non-video bidders from video ad units (prebid#1815) Update renderAd to replace ${AUCTION_PRICE} in adUrl (prebid#1795) Pulsepoint adapter: fixing bid rejection due to missing mandatory bid params. (prebid#1823) Remove require.ensure entirely (prebid#1816) Add custom keyword support for pbs bid adapter (prebid#1763) OpenX Video Adapter update to Prebid v1.0 (prebid#1724) Fix test that hard-coded pbjs global. (prebid#1786) Update Pollux Adapter to v1.0 (prebid#1694) PubMatic adapter (prebid#1707) Added sizes to Rubicon Adapter (prebid#1818) jsonpFunction name should match the namespace (prebid#1785) Adding 33Across adapter (prebid#1805) Unit test fix (prebid#1812) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Update Pollux Adapter to v1.0
Other information
Related PR #1431