Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Touchup add bid response #1822

Merged
merged 2 commits into from
Nov 16, 2017
Merged

Conversation

kitwestneat
Copy link
Contributor

Type of change

  • Refactoring (no functional changes, no api changes)

Description of change

The first commit modifies helper functions in addBidResponse to explicitly pass in closure variables. The second commit moves them out of addBidResponse closure.

Other information

In PR#1814 we talked about ways to improve the readability of addBidResponse and it was decided that we'd pass in the closure variables explicitly. I also added a patch that moved the functions out of the closure, since it sounded like that was the prefered style. (Hopefully it's not too hard to just pull one if you don't think the closure change is necessary.)

Copy link
Member

@mkendall07 mkendall07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbemiller dbemiller assigned dbemiller and unassigned mkendall07 Nov 14, 2017
@dbemiller dbemiller merged commit 220e316 into prebid:master Nov 16, 2017
Millerrok pushed a commit to Vertamedia/Prebid.js that referenced this pull request Nov 21, 2017
* unstream/master: (36 commits)
  + Add Optimatic Bid Adapter (prebid#1837)
  Add Bridgewell adapter (prebid#1825)
  Kumma adapter updated for Prebid 1.0 (prebid#1766)
  Touchup add bid response (prebid#1822)
  Fix skipped test (prebid#1836)
  Added new size in Rubicon pbjs Adapter (prebid#1842)
  HuddledMasses header bidding adapter (prebid#1806)
  Increment pre version
  Prebid 0.33.0 Release
  Update AOL adapter for v1.0  (prebid#1693)
  Sovrn 1.0 compliance (prebid#1796)
  Platform.io Bidder Adapter update (prebid#1817)
  Drop non-video bidders from video ad units (prebid#1815)
  Update renderAd to replace ${AUCTION_PRICE} in adUrl (prebid#1795)
  Pulsepoint adapter: fixing bid rejection due to missing mandatory bid params. (prebid#1823)
  Remove require.ensure entirely (prebid#1816)
  Add custom keyword support for pbs bid adapter (prebid#1763)
  OpenX Video Adapter update to Prebid v1.0 (prebid#1724)
  Fix test that hard-coded pbjs global. (prebid#1786)
  Update Pollux Adapter to v1.0 (prebid#1694)
  ...
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
* bidmanager: pass closure variables explicitly to helper functions in addBidResponse

* bidmanager: move addBidResponse helper functions out of closures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants