Add a new bid adapter and test specs for bridgewell #1825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaiminpanchal27
requested changes
Nov 16, 2017
There was a problem hiding this comment.
@kuchunchou Thanks for adding the adapter.
Unit tests are failing. For some reason travis did not run.
Also left some comments.
modules/bridgewellBidAdapter.js
Outdated
| * @return ServerRequest Info describing the request to the server. | ||
| */ | ||
| buildRequests: function(validBidRequests) { | ||
| var channelIDs = []; |
modules/bridgewellBidAdapter.js
Outdated
| return; | ||
| } | ||
|
|
||
| bidResponse.bidderCode = spec.code; |
There was a problem hiding this comment.
bidderCode will be set by bidderFactory so you can remove this line
modules/bridgewellBidAdapter.js
Outdated
| return bidResponses; | ||
| }, | ||
|
|
||
| getUserSyncs: function(syncOptions) { |
There was a problem hiding this comment.
You can remove this function if not needed. Its optional.
|
@jaiminpanchal27 Thanks for the review. Unit tests should pass now and issues stated in your comments are also fixed accordingly. |
jaiminpanchal27
approved these changes
Nov 20, 2017
matthewlane
approved these changes
Nov 20, 2017
Millerrok
pushed a commit
to Vertamedia/Prebid.js
that referenced
this pull request
Nov 21, 2017
* unstream/master: (36 commits) + Add Optimatic Bid Adapter (prebid#1837) Add Bridgewell adapter (prebid#1825) Kumma adapter updated for Prebid 1.0 (prebid#1766) Touchup add bid response (prebid#1822) Fix skipped test (prebid#1836) Added new size in Rubicon pbjs Adapter (prebid#1842) HuddledMasses header bidding adapter (prebid#1806) Increment pre version Prebid 0.33.0 Release Update AOL adapter for v1.0 (prebid#1693) Sovrn 1.0 compliance (prebid#1796) Platform.io Bidder Adapter update (prebid#1817) Drop non-video bidders from video ad units (prebid#1815) Update renderAd to replace ${AUCTION_PRICE} in adUrl (prebid#1795) Pulsepoint adapter: fixing bid rejection due to missing mandatory bid params. (prebid#1823) Remove require.ensure entirely (prebid#1816) Add custom keyword support for pbs bid adapter (prebid#1763) OpenX Video Adapter update to Prebid v1.0 (prebid#1724) Fix test that hard-coded pbjs global. (prebid#1786) Update Pollux Adapter to v1.0 (prebid#1694) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This is a new bidder adapter pull request for Bridgewell (an buyer based in Taiwan).