Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Receiving bidderTimeout events for "No bid" responses #2146

Closed
aurelienjoneau opened this issue Feb 14, 2018 · 2 comments
Closed

Receiving bidderTimeout events for "No bid" responses #2146

aurelienjoneau opened this issue Feb 14, 2018 · 2 comments
Assignees
@snapwich
Labels
bug

Comments

@aurelienjoneau
Copy link
Contributor

Type of issue

Question

Description

Hey guys, while starting to implement this solution : #2035 , I noticed that i'm receiving bidderTimeout events for all "No bid" responses that are given back, right before the auctionEnd event.

@snapwich, Do you know how to distinguish real timeout events and "No bid" responses ?
@snapwich
Copy link
Collaborator

Created an issue, this is a bug. #2152

snapwich added a commit to rubicon-project/Prebid.js that referenced this issue Feb 15, 2018
@snapwich
only count bid timeouts if bidder didn't call done. fixes prebid#2146
dd82824
@snapwich
Copy link
Collaborator

snapwich commented Feb 15, 2018 •
edited
Loading

actually just submitted a pull-request instead; it is a small bug fix. #2154

@mkendall07 mkendall07 added the bug label Feb 21, 2018
mizmaar3 added a commit to widespace-os/Prebid.js that referenced this issue Feb 28, 2018
@mizmaar3
Merge branch 'master' into Widespace_adapter
2a7d099 
* master:
  Update Vertoz adapter for Prebid 1.0 (prebid#2104)
  Add multiple bids request  (prebid#2136)
  [NEW Adapter] RTBHouseBidAdapter (prebid#2184)
  Update Innity Adapter to Prebid.js v1.0 (prebid#2180)
  Update Adyoulike Adapter to prebid 1.0 (prebid#2077)
  Change bidderCode for DAN Marketplace Bid Adapter (prebid#2183)
  only count bid timeouts if bidder didn't call done. fixes prebid#2146 (prebid#2154)
  [Edit BidAdapter] rxrtb adapter for Perbid.js 1.0 (prebid#2182)
  Update NasmediaAdmixer adapter (prebid#2164)
  only do video caching if we don't already have a videoCacheKey (prebid#2143)
dluxemburg pushed a commit to Genius/Prebid.js that referenced this issue Jul 17, 2018
@snapwich @dluxemburg
only count bid timeouts if bidder didn't call done. fixes prebid#2146 (…
f265c51 
…prebid#2154)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snapwich snapwich

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@snapwich @matthewlane @mkendall07 @aurelienjoneau