only count bid timeouts if bidder didn't call done. fixes #2146 #2154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewlane
approved these changes
Feb 23, 2018
mizmaar3
added a commit
to widespace-os/Prebid.js
that referenced
this pull request
Feb 28, 2018
* master: Update Vertoz adapter for Prebid 1.0 (prebid#2104) Add multiple bids request (prebid#2136) [NEW Adapter] RTBHouseBidAdapter (prebid#2184) Update Innity Adapter to Prebid.js v1.0 (prebid#2180) Update Adyoulike Adapter to prebid 1.0 (prebid#2077) Change bidderCode for DAN Marketplace Bid Adapter (prebid#2183) only count bid timeouts if bidder didn't call done. fixes prebid#2146 (prebid#2154) [Edit BidAdapter] rxrtb adapter for Perbid.js 1.0 (prebid#2182) Update NasmediaAdmixer adapter (prebid#2164) only do video caching if we don't already have a videoCacheKey (prebid#2143)
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
getTimedOutBidswas erroneously including bidders as being timed out when they had calleddone. This fixes that.