Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getBidLandscapeTargeting ignores adUnitCodes paramter #2327

Closed
dmitriyshashkin opened this issue Mar 29, 2018 · 2 comments
Closed

getBidLandscapeTargeting ignores adUnitCodes paramter #2327

dmitriyshashkin opened this issue Mar 29, 2018 · 2 comments
Labels
bug

Comments

@dmitriyshashkin
Copy link
Contributor

Type of issue

bug

Description

getBidLandscapeTargeting method receives adUnitCodes parameter but never uses it. As the result when I can setTargetingForGPTAsync and specify adUnit parameter, targeting is being set on all units instead of just the one I sent as a parameter.

Steps to reproduce

  1. Create 2 units
  2. Run auction
  3. Call pbjs.setTargetingForGPTAsync('ad_unit_code_1')

Expected results

Targeting is being set on the ad unit 1, but not on the ad unit 2

Actual results

Targeting is being set on both ad units.

Platform details

1.7.0-pre but the bug also exists in 0.34 branch
@jsnellbaker jsnellbaker added the bug label Apr 2, 2018
@jsnellbaker
Copy link
Collaborator

@dmitriyshashkin Thanks for submitting this issue, we'll investigate.

@jsnellbaker jsnellbaker mentioned this issue Apr 3, 2018
Merged
1 task
mkendall07 pushed a commit that referenced this issue Apr 3, 2018
@jsnellbaker @mkendall07
Fixes issue #2327 - getBidLandScapeTargeting not using adUnitCode arg…
f463545 
…ument (#2336)

* initial commit to fix issue 2327

* switched to different include function
@jsnellbaker
Copy link
Collaborator

@dmitriyshashkin This should be fixed now in 1.7 release. If you continue to see any issues, please let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dmitriyshashkin @jsnellbaker