Fixes issue #2327 - getBidLandScapeTargeting not using adUnitCode argument #2336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaiminpanchal27
requested changes
Apr 3, 2018
src/targeting.js
Outdated
| if (bid.adserverTargeting) { | ||
| if ( | ||
| bid.adserverTargeting && adUnitCodes && | ||
| ((utils.isArray(adUnitCodes) && adUnitCodes.includes(bid.adUnitCode)) || |
There was a problem hiding this comment.
Use includes by importing it from core-js
import includes from 'core-js/library/fn/array/includes';
Usage includes(<array>, <item>
includes doesn’t work in older versions of IE. The imported version is polyfilled to work with ie, rather than Babel doing any kind of transforms that might end up not working in target browsers
There was a problem hiding this comment.
Thanks for the feedback; I just pushed a commit that switched it to the other includes function.
jaiminpanchal27
approved these changes
Apr 3, 2018
jaiminpanchal27
added
LGTM
needs 2nd review
mkendall07
approved these changes
Apr 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Previously the
getBidLandScapeTargetingfunction accepted anadUnitCodesargument, but it was never directly used inside the actual function. It's purpose was meant to provide the specific bids that match adUnitCode(s) (this param could be either a string or a list of strings).This fix introduces the proper logic to use this argument. So now if a publisher wanted to apply the targeting data for a specific ad unit from their page code (as noted in the original issue), they could call (
pbjs.setTargetingForGPTAsync('div-gpt-ad-1438287399331-0');) and it would only process that ad unit's data.Other information
Fixes issue #2327