Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RequireJS requirement #28

Closed
acookcpxi opened this issue Aug 18, 2015 · 4 comments
Closed

RequireJS requirement #28

acookcpxi opened this issue Aug 18, 2015 · 4 comments

Comments

@acookcpxi
Copy link

We're having issues attempting to implement on a site that does not already have RequireJS implemented - could the integration example file be updated to include RequireJS and exaplin for people who do not use it regularly how to implement? As it is now our site breaks when we follow the integration example that is posted...

@ialex
Copy link
Contributor

ialex commented Aug 18, 2015

Can you share your code on how you are trying to implemment it?

@Heray
Copy link

Heray commented Aug 18, 2015

Hey @acookcpxi, if you're trying to implement prebid.js, see the latest release as a good place to start:
https://github.com/prebid/Prebid.js/releases

If you're trying to contribute to the repo, I think require() is part of the Gulp tool when you're building the Javascript. In the final prebid.js, there would be no require() call.

@mkendall07, could you also help out here?

@mkendall07
Copy link
Member

Hi @acookcpxi,

We actually don't use requireJS in this project at all. Browserify (http://browserify.org) is used to build all the modules and bundle one prebid.js file. Consuming this file should not require any additional dependencies. If you post a link to your code I'd be happy to point out more.

@acookcpxi
Copy link
Author

Thanks, I hadn’t done the gulp step as I was just including the file that was downloaded from GIT…

From: mkendall
Reply-To: "prebid/Prebid.js"
Date: Wednesday, August 19, 2015 at 4:52 PM
To: "prebid/Prebid.js"
Cc: Alex Cook
Subject: Re: [Prebid.js] RequireJS requirement (#28)

Hi @acookcpxihttps://github.com/acookcpxi,

We actually don't use requireJS in this project at all. Browserify (http://browserify.org) is used to build all the modules and bundle one prebid.js file. Consuming this file should not require any additional dependencies. If you post a link to your code I'd be happy to point out more.


Reply to this email directly or view it on GitHubhttps://github.com//issues/28#issuecomment-132780349.

lntho referenced this issue in openx/Prebid.js Oct 11, 2016
cleanup(openx adapter): cleanup the openx prebid adapter
kd-appier pushed a commit to appier/Prebid.js that referenced this issue May 30, 2019
Fix broken unit test for appier analytic adapter.

Approved-by: Yuan-Hung Huang <yuanhung.huang@appier.com>
ecammit pushed a commit to imediabrands/Prebid.js that referenced this issue Feb 3, 2022
…ster

* commit 'fe450e68a4ff3e6dc6267862b4888ea0ac3680e8':
  feature/CAP-2516: Remove the filtering of eids for synacormediaBidAdapter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants