Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bidsBackHandler arguments are incomplete #5355

Closed
natanavra opened this issue Jun 10, 2020 · 3 comments
Closed

bidsBackHandler arguments are incomplete #5355

natanavra opened this issue Jun 10, 2020 · 3 comments
Assignees

Comments

@natanavra
Copy link

Type of issue

Bug

Description

bidsBackHandler is called with an empty object when no bids are available (added after #3197).
bidsBackHandler should be called with the auction object to allow to refresh relevant slots.
e.g. if several auctions are initiated one after the other on multiple dynamically loaded slots, each slot / group of slots should be refreshed separately, calling a generic refresh would cause all slots to refresh - and that's not wanted behavior.

Steps to reproduce

  1. Call pbjs.requestBids with timeout of 10 so that all auctions timeout and a bidsBackHandler with 1-2 adUnits, not all.
  2. Wait for auction to end
  3. bidsBackHandler called with empty object as first argument.

Test page

const adUnits = [{
	code: slot.getSlotElementId(),
  mediaTypes: {
    banner: {
      sizes: [320, 50]
    }
  },
  bids: getBidders(),
}];

pbjs.requestBids({
  adUnits: adUnits,
  bidsBackHandler: initAdServer,
  timeout: 10,
});

function initAdServer(bids) {
  // bids == {}
}

Expected results

First bidsBackHandler parameter to be a list of bids for each adUnit, or the auction object sent in auctionEnd - so it can be used to identify which adUnits bidded on.

Actual results

Empty object.

Platform details

Prebid 3.18.0
Chrome, Mac OS

Other information

Related:

@stale
Copy link

stale bot commented Jul 6, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 6, 2020
@stale stale bot removed the stale label Jul 8, 2020
@stale
Copy link

stale bot commented Jul 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 25, 2020
@stale
Copy link

stale bot commented Aug 8, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot closed this as completed Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants