Fixes #3197 - call auctionDone() when 'No valid bid requests returned for auction' #3198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…turned for auction'
|
@drdmitry Code looks good. Please add unit test |
…quests is empty
jaiminpanchal27
approved these changes
Oct 23, 2018
idettman
pushed a commit
to rubicon-project/Prebid.js
that referenced
this pull request
Nov 14, 2018
…turned for auction' (prebid#3198) * Fixes prebid#3197 - call auctionDone() when 'No valid bid requests returned for auction' * prebid#3197 Added unit test to check if callback is called when bidRequests is empty
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
…turned for auction' (prebid#3198) * Fixes prebid#3197 - call auctionDone() when 'No valid bid requests returned for auction' * prebid#3197 Added unit test to check if callback is called when bidRequests is empty
pedrolopezmrf
pushed a commit
to Marfeel/Prebid.js
that referenced
this pull request
Mar 18, 2019
…turned for auction' (prebid#3198) * Fixes prebid#3197 - call auctionDone() when 'No valid bid requests returned for auction' * prebid#3197 Added unit test to check if callback is called when bidRequests is empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
call auctionDone() when 'No valid bid requests returned for auction'
Type of change
Description of change
When 'No valid bid requests returned for auction' we do call
auctionDone()to havebidsBackHandlergets called.Other information
#3197