Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When "No valid bid requests returned for auction" bidsBackHandler never gets called #3197

Closed
drdmitry opened this issue Oct 18, 2018 · 0 comments
Closed

When "No valid bid requests returned for auction" bidsBackHandler never gets called #3197

drdmitry opened this issue Oct 18, 2018 · 0 comments
Assignees
@jaiminpanchal27

Comments

@drdmitry
Copy link
Contributor

Type of issue

Bug

Description

requestBids() with specified bidsBackHandler doesn't call callback function (bidsBackHandler) when there are "No valid bid requests returned for auction".

Steps to reproduce

Call requestBids() when no bids available, specify bidsBackHandler callback function.

Test page

Expected results

Auction to be finished with warning
"No valid bid requests returned for auction"
and callback function (bidsBackHandler) expected be called (as on auctionDone()).

Actual results

Auction will be finished with warning
"No valid bid requests returned for auction"
and callback function (bidsBackHandler) would not be called.

Platform details

1.26.0

Other information

#3137
drdmitry pushed a commit to drdmitry/Prebid.js that referenced this issue Oct 18, 2018
Fixes prebid#3197 - call auctionDone() when 'No valid bid requests re…
535ea0d 
…turned for auction'
@drdmitry drdmitry mentioned this issue Oct 18, 2018
Merged
1 task
@jaiminpanchal27 jaiminpanchal27 self-assigned this Oct 18, 2018
drdmitry pushed a commit to drdmitry/Prebid.js that referenced this issue Oct 23, 2018
prebid#3197 Added unit test to check if callback is called when bidRe…
83228f7 
…quests is empty
idettman pushed a commit to rubicon-project/Prebid.js that referenced this issue Nov 14, 2018
@drdmitry
Fixes prebid#3197 - call auctionDone() when 'No valid bid requests re…
1e81456 
…turned for auction' (prebid#3198)

* Fixes prebid#3197 - call auctionDone() when 'No valid bid requests returned for auction'

* prebid#3197 Added unit test to check if callback is called when bidRequests is empty
ghost pushed a commit to devunrulymedia/Prebid.js that referenced this issue Jan 30, 2019
@drdmitry
Fixes prebid#3197 - call auctionDone() when 'No valid bid requests re…
88141e5 
…turned for auction' (prebid#3198)

* Fixes prebid#3197 - call auctionDone() when 'No valid bid requests returned for auction'

* prebid#3197 Added unit test to check if callback is called when bidRequests is empty
pedrolopezmrf pushed a commit to Marfeel/Prebid.js that referenced this issue Mar 18, 2019
@drdmitry
Fixes prebid#3197 - call auctionDone() when 'No valid bid requests re…
59109b1 
…turned for auction' (prebid#3198)

* Fixes prebid#3197 - call auctionDone() when 'No valid bid requests returned for auction'

* prebid#3197 Added unit test to check if callback is called when bidRequests is empty
@natanavra natanavra mentioned this issue Jun 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaiminpanchal27 jaiminpanchal27

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@drdmitry @jaiminpanchal27