Dxkulture Bid Adapter: changing default video placement value #10473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patmmccann
previously requested changes
Sep 12, 2023
modules/dxkultureBidAdapter.js
Outdated
| @@ -329,7 +329,7 @@ function buildVideoRequestData(bidRequest, bidderRequest) { | |||
|
|
|||
| // Placement Inference Rules: | |||
| // - If no placement is defined then default to 1 (In Stream) | |||
| video.placement = video.placement || 2; | |||
| video.placement = video.placement || 1; | |||
There was a problem hiding this comment.
video.placement is deprecated; why not also support plcmt? The reason for the deprecation was actually logic like this; the buy side described instream as over-specified.
Also pls cover in unit tests; this should have broken an existing test. The fact that it didnt shows your adapter is under-covered.
There was a problem hiding this comment.
@patmmccann We are still operating on openrtb 2.5. We made suggested changes
ChrisHuie
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Feature
New bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Changing default video placement value