Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dxkulture Bid Adapter: changing default video placement value #10473

Merged
merged 3 commits into from
Sep 27, 2023
Merged

Dxkulture Bid Adapter: changing default video placement value #10473

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
10e57d6
Changing default value for video placement
Sep 12, 2023
7666cc6
Merge remote-tracking branch 'upstream/master' into dxkultureBidAdapt…
Sep 18, 2023
07f6d30
Adjusting video placement parameter
Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/dxkultureBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,7 @@ function buildVideoRequestData(bidRequest, bidderRequest) {

// Placement Inference Rules:
// - If no placement is defined then default to 1 (In Stream)
video.placement = video.placement || 2;
video.placement = video.placement || 1;
Copy link
Collaborator

@patmmccann patmmccann Sep 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

video.placement is deprecated; why not also support plcmt? The reason for the deprecation was actually logic like this; the buy side described instream as over-specified.

Also pls cover in unit tests; this should have broken an existing test. The fact that it didnt shows your adapter is under-covered.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patmmccann We are still operating on openrtb 2.5. We made suggested changes


// - If product is instream (for instream context) then override placement to 1
if (params.context === 'instream') {
Expand Down