Outbrain adapter: send placement and plcmt fields separately #11799
Conversation
|
Hi Outbrain team! It appears your adapter shares several common code blocks with other adapters. Please import them from a library or constants definition table. Thanks! |
|
You code duplication generator started checking more adapters with your last commit, you can ignore pairs without your adapter, eg adform to dianomi |
|
Thanks for moving setonany, it seems only your tests aren't passing and this will be ready to merge when it is. Keep to the great work to get the code duplication solved on your next pr or feel free to finish it here. Looks like transformSizes is ripe for a move or a refactor to use existing patterns |
patmmccann
changed the title
| @@ -390,7 +390,8 @@ describe('Outbrain Adapter', function () { | |||
| minduration: 3, | |||
| maxduration: 10, | |||
| startdelay: 2, | |||
| placement: 4, | |||
| placement: 5, | |||
| plcmt: 4, | |||
| linearity: 1 | |||
There was a problem hiding this comment.
I think you simply ordered these two lines differently than your tests expected
There was a problem hiding this comment.
Nope, it should be ok like this. Locally all the tests pass, I am really not sure what is the problem. Can you see excected vs. actual diff on circle ci?
There was a problem hiding this comment.
It passed, if you print it to console somehow you can, but I'm sure others have a better way
|
Btw did you see #11748 |
…11799) * start sending placement and placmt separately * move setOnAny function to utils * remove transformSizes and use util function
…11799) * start sending placement and placmt separately * move setOnAny function to utils * remove transformSizes and use util function
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
We would like to read both fields
Other information