Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outbrain adapter: send placement and plcmt fields separately #11799

Merged
merged 5 commits into from
Jul 1, 2024
Merged

Outbrain adapter: send placement and plcmt fields separately #11799

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7cd39ed
start sending placement and placmt separately
markkuhar Jun 14, 2024
d7a8895
Merge branch 'master' into outbrain-adapter-placement-plcmt-fields
markkuhar Jun 28, 2024
8c42166
move setOnAny function to utils
markkuhar Jul 1, 2024
443915f
remove transformSizes and use util function
markkuhar Jul 1, 2024
0bb693c
Merge branch 'master' into outbrain-adapter-placement-plcmt-fields
markkuhar Jul 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion modules/outbrainBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,8 @@ function getVideoAsset(bid) {
minduration: bid.mediaTypes.video.minduration,
maxduration: bid.mediaTypes.video.maxduration,
startdelay: bid.mediaTypes.video.startdelay,
placement: bid.mediaTypes.video.plcmt ?? bid.mediaTypes.video.placement,
placement: bid.mediaTypes.video.placement,
plcmt: bid.mediaTypes.video.plcmt,
linearity: bid.mediaTypes.video.linearity
};
}
Expand Down
3 changes: 2 additions & 1 deletion test/spec/modules/outbrainBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,8 @@ describe('Outbrain Adapter', function () {
minduration: 3,
maxduration: 10,
startdelay: 2,
placement: 4,
placement: 5,
plcmt: 4,
linearity: 1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you simply ordered these two lines differently than your tests expected

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, it should be ok like this. Locally all the tests pass, I am really not sure what is the problem. Can you see excected vs. actual diff on circle ci?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It passed, if you print it to console somehow you can, but I'm sure others have a better way

}
}
Expand Down
Loading