Modernizing build dependencies #1355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n up the browserstack logs.
…ody needs anymore.
…wserstack look good again.
protonate
reviewed
Jul 10, 2017
| var webpack = require('webpack-stream'); | ||
| var path = require('path'); | ||
| var webpack = require('webpack'); | ||
| var webpackStream = require('webpack-stream'); |
There was a problem hiding this comment.
Is there a reason to require both webpack and webpackStream? Docs seem to indicate stream is a drop-and-replace.
There was a problem hiding this comment.
It's under the Usage header.
If you would like to use a different version of webpack than the one this plugin uses, pass in an optional 2nd argument
They're using webpack 1.12.9.
|
@snapwich appreciate your review on these changes. |
matthewlane
approved these changes
Jul 17, 2017
outoftime
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 28, 2017
…built * 'master' of https://github.com/prebid/Prebid.js: (95 commits) Specify --browsers when using gulp test --watch (prebid#1420) Added aliases for aol adapter. (prebid#1371) Added MobFox Adapter (prebid#1312) Fixed style error. (prebid#1419) Add native support for Criteo adapter (prebid#999) Update admediaBidAdapter.js (prebid#1395) Increment pre version (prebid#1413) Prebid 0.26.1 Release (prebid#1412) fix prebid#1410 - issue with ie and xhr.timeout (prebid#1411) Lint modules directory (prebid#1404) Set outstream mediaType based on renderer in response (prebid#1391) Fixing the BidAdjustmentEvent fire time (prebid#1399) Fix banner showing up in prebid-core.js (prebid#1388) Mention NodeJS 4.0 dependency in the README (prebid#1386) Increment pre version (prebid#1385) Prebid 0.26.0 Release (prebid#1384) PulsePoint Lite adapter - adding createNew method for aliasing. (prebid#1383) Modernizing build dependencies (prebid#1355) StickyAdsTV bidder adapter update (prebid#1311) Added CPM value as parameter for Vertoz Adapter (prebid#1306) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Build upgrades & maintenance
Description of change
Lots of build maintenance relating to webpack, istanbul, and karma.
Fixed bugs
gulp test —browserstackis much more conciseMaintenance
gulp test-coveragecommand.gulp testno longer generates coverage.gulp run-testsusesgulp test-coverage, whilegulp serveusesgulp test.Performance Comparison
These were very un-scientific... I only ran each test once, and didn't pay attention to my machine load. I can run more careful trials if anyone really cares though.
Old build (from Master)
prebid.js bundle size — 269KB
npm install— 31syarn install— 20.45sgulp build— 13sgulp lint— 6sgulp run-tests— 1m1sNew build (from this branch)
prebid.js bundle size — 264KB
npm install— 25syarn install— 18.59sgulp build— 15sgulp lint— 5sgulp test— 37sgulp run-tests— 1m17s (no longer used bygulp serve)gulp test --browserstack-- About 10 minutes