Fixing the BidAdjustmentEvent fire time #1399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewlane
reviewed
Jul 20, 2017
test/spec/unit/bidmanager_spec.js
Outdated
| @@ -142,6 +157,21 @@ describe('The Bid Manager', () => { | |||
| bidManager.addBidResponse('mock/code'); | |||
| expect($$PREBID_GLOBAL$$._bidsReceived.length).to.equal(0); | |||
| }); | |||
|
|
|||
| it('should attach properties for analytics *before* the BID_ADJUSTMENT event listeners are called', () => { | |||
| console.log('testing this bug'); | |||
There was a problem hiding this comment.
Looks like this console.log slipped through 🐍
matthewlane
approved these changes
Jul 20, 2017
outoftime
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 28, 2017
…built * 'master' of https://github.com/prebid/Prebid.js: (95 commits) Specify --browsers when using gulp test --watch (prebid#1420) Added aliases for aol adapter. (prebid#1371) Added MobFox Adapter (prebid#1312) Fixed style error. (prebid#1419) Add native support for Criteo adapter (prebid#999) Update admediaBidAdapter.js (prebid#1395) Increment pre version (prebid#1413) Prebid 0.26.1 Release (prebid#1412) fix prebid#1410 - issue with ie and xhr.timeout (prebid#1411) Lint modules directory (prebid#1404) Set outstream mediaType based on renderer in response (prebid#1391) Fixing the BidAdjustmentEvent fire time (prebid#1399) Fix banner showing up in prebid-core.js (prebid#1388) Mention NodeJS 4.0 dependency in the README (prebid#1386) Increment pre version (prebid#1385) Prebid 0.26.0 Release (prebid#1384) PulsePoint Lite adapter - adding createNew method for aliasing. (prebid#1383) Modernizing build dependencies (prebid#1355) StickyAdsTV bidder adapter update (prebid#1311) Added CPM value as parameter for Vertoz Adapter (prebid#1306) ...
vzhukovsky
added a commit
to aol/Prebid.js
that referenced
this pull request
Sep 6, 2017
….25.0 to aolgithub-master * commit '2a31c81b71595988ed2bf3470fb94d4fb75098bc': (71 commits) Sync with contrib/aol-adapter-aliases branch. Added junit reporter, improved browserstack tests running. Change browsers config to allow run tests on CI. Temporary comment unit test to provide compatibility with pre-bidder timeout feature. Added banner for minified source file. Improve matching to avoid breaking js syntax. Changed changelog entry. Fixed invalid module link. Prebid 0.26.1 Release (prebid#1412) fix prebid#1410 - issue with ie and xhr.timeout (prebid#1411) Lint modules directory (prebid#1404) Added changelog entry. Added ids in aolPartnersIds. Added tests for delimiterLoader. Set outstream mediaType based on renderer in response (prebid#1391) Fixing the BidAdjustmentEvent fire time (prebid#1399) Improved adapter source code wrappig. Changed aol analytics adapter to new structure. Get rid of preserve keyword. Added preserved keyword for adapters wrapping. ...
jbAdyoulike
pushed a commit
to jbAdyoulike/Prebid.js
that referenced
this pull request
Sep 21, 2017
* Fired the bid adjustment event at (what I think is) the appropriate time. * More thorough tests. * Better test description. * Removed a stray console.log
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
* Fired the bid adjustment event at (what I think is) the appropriate time. * More thorough tests. * Better test description. * Removed a stray console.log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Description of change
Fixing #1398.
...turns out that the timing of
BidAdjustmentis very fragile, and people are relying on in to be after some bid mutations, but before some others. This puts it (I think) where it's supposed to be, and adds some regression tests.