Pass the adUnit array when emitting SET_TARGETING #1875
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use this in our analytics adapter very useful to have as args
mkendall07
requested changes
Nov 27, 2017
| @@ -230,7 +230,7 @@ $$PREBID_GLOBAL$$.setTargetingForGPTAsync = function (adUnit) { | |||
| targeting.setTargeting(targetingSet); | |||
|
|
|||
| // emit event | |||
| events.emit(SET_TARGETING); | |||
| events.emit(SET_TARGETING, adUnit); | |||
There was a problem hiding this comment.
adUnit is optional here. Probably better to define some structure. Is this an array, object etc?
There was a problem hiding this comment.
Once that is done, it should be applied to the other SET_TARGETING emitter - see line 250
There was a problem hiding this comment.
Just to be clear, my preference is something like:
events.emit(SET_TARGETING, { adUnits: [adUnit1, adUnitN...]});
There was a problem hiding this comment.
Thanks for the feedback. Will fix!
|
@ptomasroos |
|
Yes will fix tomorrow GMT time @mkendall07 forgot |
|
@ptomasroos - any update? |
|
closing as no update in several months. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use this in our analytics adapter very useful to have as args
Description of change
Since the auction process is detached from the DFP rendering process aka when does a call against DFP happen we find it very useful in our analytics adapter to have which ad unit's or all are getting invoked