Consistent targeting set #2592
Merged
Consistent targeting set #2592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snapwich
requested changes
May 30, 2018
src/targeting.js
Outdated
| targeting.push(emptyTargeting); | ||
| } | ||
| }); | ||
|
|
There was a problem hiding this comment.
I think this could be greatly simplified by replacing it with the following code after the flattenTargeting is called below
adUnitCodes.forEach(code => {
if (!targeting[code]) {
targeting[code] = {};
}
});
There was a problem hiding this comment.
Good point! Will give it a try
|
Updated, all tests run as expect @snapwich |
snapwich
added
the
needs 2nd review
jaiminpanchal27
approved these changes
Jun 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
The idea is that users of SET_TARGETING who receives the argument targeting set, should be able to get the ad unit codes always involved even though a bid not might be available when rendering the ad
Other information
Previously I tried to introduce the adUnits into the arguments #1875
and since then the targetingSet has been starting to get passed. In order to make this without breaking any contracts my suggestion is that we always return a entry even though there is no bid available to the receiver of SET_TARGETING can iterate which ad unit codes are getting invoked.