Add support for Gamoshi's Gambid Bid Adapter #2625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging 9a71939 into f7cf6cb - view on lgtm.com new alerts:
Comment posted by lgtm.com |
|
This pull request introduces 1 alert when merging f7bf27d into f7cf6cb - view on lgtm.com new alerts:
Comment posted by lgtm.com |
arikkfir
changed the title
snapwich
requested changes
May 29, 2018
There was a problem hiding this comment.
It looks like you're missing the new GDPR compliance details. looks good other than that. http://prebid.org/dev-docs/modules/consentManagement.html
This commit utilizes Prebid.js's GDPR framework for passing user's consent to our server. This includes both the actual bid request & the user-syncs request.
|
Thanks @snapwich - done. |
|
@snapwich quick question - so on the next Prebid.js release users will be able to check the "Gamoshi Gambid" check-box? |
Pupis
pushed a commit
to adform/Prebid.js
that referenced
this pull request
Jun 7, 2018
* Initial submission of Gamoshi's Gambid Bid Adapter * fix failing test and remove redundant "&" in URL * fix minor suggestion from lgtm * fix test of user-sync pixels * another fix for the user-sync tests * fix JS lint error re spaces inside parenthesis * Add GDPR support This commit utilizes Prebid.js's GDPR framework for passing user's consent to our server. This includes both the actual bid request & the user-syncs request. * Fix small bug & test in GDPR support, and few minor linting issues
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
* Initial submission of Gamoshi's Gambid Bid Adapter * fix failing test and remove redundant "&" in URL * fix minor suggestion from lgtm * fix test of user-sync pixels * another fix for the user-sync tests * fix JS lint error re spaces inside parenthesis * Add GDPR support This commit utilizes Prebid.js's GDPR framework for passing user's consent to our server. This includes both the actual bid request & the user-syncs request. * Fix small bug & test in GDPR support, and few minor linting issues
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
* Initial submission of Gamoshi's Gambid Bid Adapter * fix failing test and remove redundant "&" in URL * fix minor suggestion from lgtm * fix test of user-sync pixels * another fix for the user-sync tests * fix JS lint error re spaces inside parenthesis * Add GDPR support This commit utilizes Prebid.js's GDPR framework for passing user's consent to our server. This includes both the actual bid request & the user-syncs request. * Fix small bug & test in GDPR support, and few minor linting issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Add support for Gamoshi's Gambid Platform to Prebid.js in the form of a new bidder adapter.
Here's how to simulate an example bid for testing:
Contact email of the adapter’s maintainer: arik@gamoshi.com