Include gdpr TripleLift #2663

brittanyzellman · 2018-05-31T15:41:47Z

Type of change

Bugfix
Feature
New bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other

Description of change

Upgraded to 1.12 to include SRA capability and GDPR compliance module.

contact email of the adapter’s maintainer
bzellman@triplelift.com
official adapter submission

mkendall07 · 2018-05-31T15:49:31Z

This pull request introduces 1 alert when merging 45efe0e into 476cad8 - view on lgtm.com

new alerts:

1 for Useless conditional

Comment posted by lgtm.com

mkendall07 · 2018-05-31T16:45:48Z

This pull request introduces 1 alert when merging 2ebff0c into 476cad8 - view on lgtm.com

new alerts:

1 for Useless conditional

Comment posted by lgtm.com

brittanyzellman · 2018-05-31T18:00:45Z

@mkendall07 I would like to reach out various publishers with a timeline of when they can expect the adapter to be deployed. Pending all tests/approval, when can I expect a merge and deploy?
Thanks!

mkendall07 · 2018-05-31T18:21:33Z

integrationExamples/gpt/custom.html

@@ -0,0 +1,186 @@
+<html>


please remove this file. We already have a gdpr hello world example.

YOzaz · 2018-06-01T07:53:33Z

We're a publisher, and waiting for TripleLift to be merged... hope it'll be today?

ehoch · 2018-06-02T16:09:00Z

@brittanyzellman This is causing

``Error processing command : Cannot read property 'gdprApplies' of undefined TypeError: Cannot read property 'gdprApplies' of undefined```

If the consent module is included, but not configured (like we have in the case of our non-EU traffic). Can you add a check for existence of bidderRequest.gdprConsent ?

brittanyzellman · 2018-06-08T19:24:46Z

@mkendall07 checking back in here for any timeline info you can give us? We have publishers asking and aren't quite sure what to tell them to expect in terms of deployment.

ptim · 2018-06-12T06:04:13Z

@brittanyzellman not sure, but merge may be waiting on removal of integrationExamples/gpt/custom.html, per:

please remove this file. We already have a gdpr hello world example.

#2663 (comment)

…s into include-gdpr-tl 'removed custom.html'

brittanyzellman · 2018-06-14T13:04:34Z

All irrelevant files are deleted and adapter passes all checks. Still waiting for a timeline as to when publishers can expect this to be merged and deployed? @mkendall07

ptim · 2018-06-15T00:49:47Z

I'm a pub using triplelift - can I request some documentation for configuring native ad units under Prebid v1?

It appears that it's necessary to send bid requests for our native ad slots as mediaType.banner with a [1,1] size rather than using the native ad configuration... I only discovered this via experimentation - can't see it documented anywhere (there's no readme for this adapter, and no entry in the prebid docs repo).

TIA

brittanyzellman · 2018-06-15T16:01:40Z

@ptim please reach out to your point of contact at Triplelift. They will have all relevant documentation on how to integrate. I'm assuming that you are already integrated with us through Prebid?

YOzaz · 2018-06-18T09:59:43Z

@ptim Triplelift does not support "real" pbjs native bidding, but rather is a wrapper for [1,1] auto-expanding ad. Same is for Sharethrough, for example.

brittanyzellman · 2018-06-19T18:27:09Z

@mkendall07 reaching out again for a timeline on getting this merged and deployed... if there is someone else I should add as a reviewer and call out here I'm happy to do so. Please let me know..

mkendall07

@brittanyzellman
You need to include a test spec file and a bidder markdown file. Please see http://prebid.org/dev-docs/bidder-adaptor.html#adding-unit-tests for example.

brittanyzellman · 2018-07-05T13:27:29Z

@mkendall07 any word on when we can expect this to be merged/deployed?

mkendall07

Just a few small updates needed. Overall LGTM. Thanks!
Also your at 79.31% unit test coverage which is slightly short but I'll let it slide :)

mkendall07 · 2018-07-09T19:21:21Z

modules/tripleliftBidAdapter.md

+           floor: 1.009
+        }
+    },{
+        bidder: 'appnexus',


any reason you included an AppNexus bid in your test?

mkendall07 · 2018-07-09T19:28:31Z

modules/tripleliftBidAdapter.js

+
+const BIDDER_CODE = 'triplelift';
+const STR_ENDPOINT = document.location.protocol + '//tlx.3lift.com/header/auction?';
+var applies = true;


prefer let over var

a better name here would be gdprApplies

mkendall07 · 2018-07-09T19:30:27Z

modules/tripleliftBidAdapter.js

+
+  code: BIDDER_CODE,
+  supportedMediaTypes: [BANNER],
+  aliases: ['triplelift'],


not necessary to alias your own code.

mkendall07 · 2018-07-09T19:42:33Z

@brittanyzellman
See comments above.

brittanyzellman · 2018-07-10T00:46:40Z

@mkendall07 all changes are made, I had AN in the sample for testing just so to see whether other bidders were able to load and bid but I've removed it from the md file.
Thanks!

mkendall07 · 2018-07-10T15:37:09Z

@brittanyzellman
Thanks for the changes. One last thing, please open a PR to add

prebid_1_0_supported : true
gdpr_supported: true

To the header of this file:
https://github.com/prebid/prebid.github.io/blob/master/dev-docs/bidders/triplelift.md

mkendall07 · 2018-07-10T20:15:26Z

@brittanyzellman
also please see: #2833

* added triplelift bid adapter to modules * need to host * updated adapter to 1.12 * removed useless conditional * fixed unused-variable error * fixed flash method * had two versions of the consent method, initially pushed the wrong one * added tmax to query string * fixed linter error * fixed linter error * tested for valid bid request * finished writing tests * added markdown file * slight change to md file * removed single quotes * deleted commented out import statement * small changes requested by MK * removed an from testing

…lman/Prebid.js/tree/include-gdpr-tl See: prebid#2663

* added triplelift bid adapter to modules * need to host * updated adapter to 1.12 * removed useless conditional * fixed unused-variable error * fixed flash method * had two versions of the consent method, initially pushed the wrong one * added tmax to query string * fixed linter error * fixed linter error * tested for valid bid request * finished writing tests * added markdown file * slight change to md file * removed single quotes * deleted commented out import statement * small changes requested by MK * removed an from testing

brittanyzellman added 3 commits May 3, 2018 13:35

added triplelift bid adapter to modules

efccfff

need to host

ca4d949

updated adapter to 1.12

45efe0e

brittanyzellman added 2 commits May 31, 2018 12:17

removed useless conditional

1c19dd6

fixed unused-variable error

2ebff0c

fixed flash method

731c1b3

mkendall07 reviewed May 31, 2018

View reviewed changes

mkendall07 changed the title ~~Include gdpr tl~~ Include gdpr TripleLift May 31, 2018

jaiminpanchal27 assigned mkendall07 Jun 1, 2018

brittanyzellman added 3 commits June 2, 2018 23:10

had two versions of the consent method, initially pushed the wrong one

e4f0266

added tmax to query string

2f8e312

fixed linter error

8e8e162

brittanyzellman added 2 commits June 12, 2018 09:58

fixed linter error

1fe571f

Merge branch 'include-gdpr-tl' of github.com:brittanyzellman/Prebid.j…

8f41770

…s into include-gdpr-tl 'removed custom.html'

mkendall07 requested changes Jun 19, 2018

View reviewed changes

mkendall07 added the needs update label Jun 19, 2018

brittanyzellman added 2 commits June 20, 2018 09:48

tested for valid bid request

93596b6

finished writing tests

3946d9f

brittanyzellman added 4 commits June 20, 2018 16:05

added markdown file

566a26c

slight change to md file

5b76fe4

removed single quotes

39a8482

deleted commented out import statement

1bd8baf

mkendall07 added needs review and removed needs update labels Jun 21, 2018

mkendall07 approved these changes Jul 9, 2018

View reviewed changes

mkendall07 added needs update LGTM and removed needs review labels Jul 9, 2018

brittanyzellman added 2 commits July 9, 2018 18:02

small changes requested by MK

dd4b70a

removed an from testing

1b82e71

mkendall07 merged commit 4319b1f into prebid:master Jul 10, 2018

jsnellbaker mentioned this pull request Jul 10, 2018

disable flash checks in triplelift adapter to allow travis build to complete without error #2833

Merged

1 task

ptim added a commit to gizmag/Prebid.js that referenced this pull request Jul 27, 2018

Add unreleased triplelift adapter from https://github.com/brittanyzel…

fb7f086

…lman/Prebid.js/tree/include-gdpr-tl See: prebid#2663

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Include gdpr TripleLift #2663

Include gdpr TripleLift #2663

brittanyzellman commented May 31, 2018 •

edited

Loading

mkendall07 commented May 31, 2018

mkendall07 commented May 31, 2018

brittanyzellman commented May 31, 2018

mkendall07 May 31, 2018

YOzaz commented Jun 1, 2018

ehoch commented Jun 2, 2018

brittanyzellman commented Jun 8, 2018

ptim commented Jun 12, 2018

brittanyzellman commented Jun 14, 2018

ptim commented Jun 15, 2018 •

edited

Loading

brittanyzellman commented Jun 15, 2018

YOzaz commented Jun 18, 2018

brittanyzellman commented Jun 19, 2018

mkendall07 left a comment •

edited

Loading

brittanyzellman commented Jul 5, 2018

mkendall07 left a comment

mkendall07 Jul 9, 2018

mkendall07 Jul 9, 2018

mkendall07 Jul 9, 2018

mkendall07 Jul 9, 2018

mkendall07 commented Jul 9, 2018

brittanyzellman commented Jul 10, 2018 •

edited

Loading

mkendall07 commented Jul 10, 2018

mkendall07 commented Jul 10, 2018

Include gdpr TripleLift #2663

Include gdpr TripleLift #2663

Conversation

brittanyzellman commented May 31, 2018 • edited Loading

Type of change

Description of change

mkendall07 commented May 31, 2018

mkendall07 commented May 31, 2018

brittanyzellman commented May 31, 2018

mkendall07 May 31, 2018

Choose a reason for hiding this comment

YOzaz commented Jun 1, 2018

ehoch commented Jun 2, 2018

brittanyzellman commented Jun 8, 2018

ptim commented Jun 12, 2018

brittanyzellman commented Jun 14, 2018

ptim commented Jun 15, 2018 • edited Loading

brittanyzellman commented Jun 15, 2018

YOzaz commented Jun 18, 2018

brittanyzellman commented Jun 19, 2018

mkendall07 left a comment • edited Loading

Choose a reason for hiding this comment

brittanyzellman commented Jul 5, 2018

mkendall07 left a comment

Choose a reason for hiding this comment

mkendall07 Jul 9, 2018

Choose a reason for hiding this comment

mkendall07 Jul 9, 2018

Choose a reason for hiding this comment

mkendall07 Jul 9, 2018

Choose a reason for hiding this comment

mkendall07 Jul 9, 2018

Choose a reason for hiding this comment

mkendall07 commented Jul 9, 2018

brittanyzellman commented Jul 10, 2018 • edited Loading

mkendall07 commented Jul 10, 2018

mkendall07 commented Jul 10, 2018

brittanyzellman commented May 31, 2018 •

edited

Loading

ptim commented Jun 15, 2018 •

edited

Loading

mkendall07 left a comment •

edited

Loading

brittanyzellman commented Jul 10, 2018 •

edited

Loading